You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by SergeVil <gi...@git.apache.org> on 2016/06/07 17:20:13 UTC
[GitHub] incubator-tinkerpop pull request #332: if there is no edge label in the Grap...
GitHub user SergeVil opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/332
if there is no edge label in the GraphML file, then use Edge.DEFAULT
As per suggestion in https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/gremlin-users/56CI2PTWueg
I'm commiting the change
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SergeVil/incubator-tinkerpop tp31-graphml
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/332.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #332
----
commit 73427e2e4e99d5332cc82e6e1f67295a91df05b6
Author: Serge Vilvovsky <se...@ll.mit.edu>
Date: 2016-06-07T17:17:55Z
if there is no edge label in the GraphML file, then use Edge.DEFAULT
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #332: if there is no edge label in the Grap...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/332
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #332: if there is no edge label in the GraphML fil...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/332
Wrong branch, please see at #333
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #332: if there is no edge label in the Grap...
Posted by analytically <gi...@git.apache.org>.
Github user analytically commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/332#discussion_r66219778
--- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLReader.java ---
@@ -187,7 +187,9 @@ public void readGraph(final InputStream graphInputStream, final Graph graphToWri
} else if (elementName.equals(GraphMLTokens.EDGE)) {
final Object[] propsAsArray = edgeProps.entrySet().stream().flatMap(e -> Stream.of(e.getKey(), e.getValue())).toArray();
final Object[] propsReady = edgeFeatures.willAllowId(edgeId) ? ElementHelper.upsert(propsAsArray, T.id, edgeId) : propsAsArray;
- edgeOutVertex.addEdge(edgeLabel, edgeInVertex, propsReady);
+
+ final String currentEdgeLabel = Optional.ofNullable(edgeLabel).orElse(Edge.DEFAULT_LABEL);
+ edgeOutVertex.addEdge(currentEdgeLabel, edgeInVertex, propsReady);
--- End diff --
spacing a little off here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---