[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1802: ZOOKEEPER-4455: Move to https://reload4j.qos.ch/ (remove log4j1)

[GitBox <gi...@apache.org>]

arshadmohammad commented on a change in pull request #1802:
URL: https://github.com/apache/zookeeper/pull/1802#discussion_r809303049



##########
File path: zookeeper-server/pom.xml
##########
@@ -77,6 +77,7 @@
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-log4j12</artifactId>
+      <scope>test</scope>

Review comment:
       After changing slf4j-log4j12 scope to test, logging is not working. I can see only following  information in log file
   
   `SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
   SLF4J: Defaulting to no-operation (NOP) logger implementation
   SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
   SLF4J: Failed to load class "org.slf4j.impl.StaticMDCBinder".
   SLF4J: Defaulting to no-operation MDCAdapter implementation.
   SLF4J: See http://www.slf4j.org/codes.html#no_static_mdc_binder for further details.
   `
   
   So some how I think we should ensure presence of slf4j implementation lib in tar ball.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org