[GitHub] [cordova-android] brodybits commented on pull request #988: [major] feat: Gradle 6.5 & Android Gradle plugin 4.0.0 updates

[GitBox <gi...@apache.org>]

brodybits commented on pull request #988:
URL: https://github.com/apache/cordova-android/pull/988#issuecomment-640299192


   > Should also update the two gradle wrapper files in the tests at:
   > 
   > https://github.com/apache/cordova-android/blob/master/test/android/wrapper.gradle
   > https://github.com/apache/cordova-android/blob/master/test/androidx/wrapper.gradle
   
   I was actually wondering why keep updating those 2 files while `bin/templates/project/wrapper.gradle` is kept blank with a comment.
   
   > Also their respective `build.gradle` files for the android gradle plugin, which currently is still at version `3.6.0`
   
   The following spec & test `build.gradle` files also seemed to be out-of-date with respect to the `build.gradle` files that I had updated.
   
   From a search I did also find `bin/templates/project/legacy/build.gradle`, wonder if we really want to keep supporting it or not.
   
   I would definitely be happy to update the test Gradle files if needed, just wanted to understand what we should be keeping up-to-date and if there is anything we should not be supporting any longer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org