[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11584: [BEAM-9136]support isRelease tag for docker build command & update release guide

[GitBox <gi...@apache.org>]

Hannah-Jiang commented on a change in pull request #11584:
URL: https://github.com/apache/beam/pull/11584#discussion_r418278914



##########
File path: sdks/python/container/py2/build.gradle
##########
@@ -66,7 +66,8 @@ docker {
                   project.rootProject["docker-tag"] : project.sdk_version)
   files "../Dockerfile", "./build"
   buildArgs(['py_version': "2.7",
-             'pull_licenses': project.rootProject.hasProperty(["docker-pull-licenses"])])
+             'pull_licenses': project.rootProject.hasProperty(["docker-pull-licenses"]) ||
+                     project.rootProject.hasProperty(["isRelease"])])

Review comment:
       Currently, the `isRelease` tag needs to be passed with commands. Ideally, this tag should be set by checking branch name.
   
   Adding this support to docker images are not that helpful for now, but could be used when we support auto setting `isRelease` tag.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org