You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/14 06:46:36 UTC

[GitHub] [maven-fluido-skin] stevecrox commented on pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search

stevecrox commented on PR #36:
URL: https://github.com/apache/maven-fluido-skin/pull/36#issuecomment-1154782537

   Could I ask the thinking behind the change?
   
   The facebook, pwiki and google analytic options all require external resources to function and even if those resources were bundled with the skin the functionality for social media and google parts require internet access to work.
   
   The css here references a CDN resource which should be cached by the browser so should mean it loads quickly.
   
   Which has me struggling to understand your motivation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org