[GitHub] [spark] prakharjain09 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitForCompletion flag to control spark-submit exit in Standalone Cluster Mode

[GitBox <gi...@apache.org>]

prakharjain09 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r411183788



##########
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##########
@@ -61,6 +61,9 @@ private class ClientEndpoint(
 
    private val lostMasters = new HashSet[RpcAddress]
    private var activeMasterEndpoint: RpcEndpointRef = null
+   private val waitAppCompletion = conf.get("spark.submit.waitAppCompletion", "false") == "true"

Review comment:
       We can use conf.getBoolean here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org