You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/02/14 09:39:03 UTC

Review Request 56648: AMBARI-20001.Workflow manager- preview workflow has xml encodings

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56648/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-20001
    https://issues.apache.org/jira/browse/AMBARI-20001


Repository: ambari


Description
-------

Replaced encoded xml strings with actual values


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js dde012d 
  contrib/views/wfmanager/src/main/resources/ui/app/components/preview-dialog.js cd6c171 
  contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js a2210a6 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs bbf7ce1 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js e793aac 

Diff: https://reviews.apache.org/r/56648/diff/


Testing
-------

Manual Testing


Thanks,

Padma Priya N


Re: Review Request 56648: AMBARI-20001.Workflow manager- preview workflow has xml encodings

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56648/#review165496
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 14, 2017, 9:39 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56648/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 9:39 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20001
>     https://issues.apache.org/jira/browse/AMBARI-20001
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Replaced encoded xml strings with actual values
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js dde012d 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/preview-dialog.js cd6c171 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js a2210a6 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs bbf7ce1 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js e793aac 
> 
> Diff: https://reviews.apache.org/r/56648/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>


Re: Review Request 56648: AMBARI-20001.Workflow manager- preview workflow has xml encodings

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56648/#review165478
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On Feb. 14, 2017, 9:39 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56648/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 9:39 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20001
>     https://issues.apache.org/jira/browse/AMBARI-20001
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Replaced encoded xml strings with actual values
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js dde012d 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/preview-dialog.js cd6c171 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js a2210a6 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs bbf7ce1 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js e793aac 
> 
> Diff: https://reviews.apache.org/r/56648/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>