You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/22 05:49:22 UTC

[GitHub] [flink] zhijiangW commented on issue #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

zhijiangW commented on issue #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment
URL: https://github.com/apache/flink/pull/8463#issuecomment-494661586
 
 
   Thanks for the updates @azagrebin!
   
   I left several minor comments, only one concern of new proposed `PartitionProducerChecker` which seems to provide the similar function as current `PartitionProducerStateChecker`. The only difference is the parameter `JobID` in `PartitionProducerStateChecker#requestPartitionProducerState`. And the `JobID` is not used in current process, so we might remove this parameter and then no need to introduce the new interface `PartitionProducerChecker`. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services