[GitHub] [flink] sunjincheng121 commented on a change in pull request #8847: [FLINK-12609][python] Align the Python data types with Java

[GitBox <gi...@apache.org>]

sunjincheng121 commented on a change in pull request #8847: [FLINK-12609][python] Align the Python data types with Java
URL: https://github.com/apache/flink/pull/8847#discussion_r297952647
 
 

 ##########
 File path: flink-python/pyflink/table/table_environment.py
 ##########
 @@ -494,9 +494,11 @@ def verify_obj(obj):
             raise TypeError(
                 "schema should be RowType, list, tuple or None, but got: %s" % schema)
 
+        # verifies the elements against the specified schema
+        elements = map(verify_obj, elements)
         # converts python data to sql data
         elements = [schema.to_sql_type(element) for element in elements]
-        return self._from_elements(map(verify_obj, elements), schema)
+        return self._from_elements(elements, schema)
 
 Review comment:
   Good catch!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services