You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2019/02/02 07:19:36 UTC

[jclouds/jclouds] Remove JavaScript from footer (#1271)

Addresses an error while building Javadoc.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1271

-- Commit Summary --

  * Remove JavaScript from footer

-- File Changes --

    M project/pom.xml (13)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1271.patch
https://github.com/jclouds/jclouds/pull/1271.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1271

Re: [jclouds/jclouds] Remove JavaScript from footer (#1271)

Posted by Andrew Gaul <no...@github.com>.
gaul commented on this pull request.



> @@ -1120,19 +1120,6 @@
             <links>
               <link>http://download.oracle.com/javase/6/docs/api/</link>
             </links>
-            <footer><![CDATA[
-            <!-- Google Analytics -->

Looks like Adrian in 0e07b7236fb594146bb8c3cd485004716f2897c0.

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1271#discussion_r253272578

Re: [jclouds/jclouds] Remove JavaScript from footer (#1271)

Posted by Andrew Gaul <no...@github.com>.
Blocks 2.1.2-rc1.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1271#issuecomment-459943148

Re: [jclouds/jclouds] Remove JavaScript from footer (#1271)

Posted by Ignasi Barrera <no...@github.com>.
nacx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1271#pullrequestreview-199339368

Re: [jclouds/jclouds] Remove JavaScript from footer (#1271)

Posted by Ignasi Barrera <no...@github.com>.
nacx commented on this pull request.



> @@ -1120,19 +1120,6 @@
             <links>
               <link>http://download.oracle.com/javase/6/docs/api/</link>
             </links>
-            <footer><![CDATA[
-            <!-- Google Analytics -->

If we have it we never used it. I think Everett added this?

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1271#discussion_r253269002

Re: [jclouds/jclouds] Remove JavaScript from footer (#1271)

Posted by Andrew Phillips <no...@github.com>.
demobox commented on this pull request.



> @@ -1120,19 +1120,6 @@
             <links>
               <link>http://download.oracle.com/javase/6/docs/api/</link>
             </links>
-            <footer><![CDATA[
-            <!-- Google Analytics -->

Out of curiosity: do we know whether there was ever a GA account associated with this?

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1271#pullrequestreview-199347099