You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/02/15 14:43:41 UTC

[Impala-ASF-CR] Revert "Update toolchain to support ubuntu 18.04" 

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12499


Change subject: Revert "Update toolchain to support ubuntu 18.04"
......................................................................

Revert "Update toolchain to support ubuntu 18.04"

This reverts commit f8c9ef48419966840b6026a7d81cfa11a3540a17, which
broke the Ubuntu 14.04 developer builds.

Change-Id: Ib8b9dd9ab2564a70bc7f01530e4d6445153f77e1
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 8 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/12499/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8b9dd9ab2564a70bc7f01530e4d6445153f77e1
Gerrit-Change-Number: 12499
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] Revert "Update toolchain to support ubuntu 18.04"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12499 )

Change subject: Revert "Update toolchain to support ubuntu 18.04"
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2141/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b9dd9ab2564a70bc7f01530e4d6445153f77e1
Gerrit-Change-Number: 12499
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 15:27:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "Update toolchain to support ubuntu 18.04"

Posted by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org>.
hector.acosta@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/12499 )

Change subject: Revert "Update toolchain to support ubuntu 18.04"
......................................................................


Patch Set 1: Code-Review-1

Added ubuntu 14.04 to 43961c5c-7ece-489c-a6e3-ec4cbe7ef4b5-b23c19a002.


-- 
To view, visit http://gerrit.cloudera.org:8080/12499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b9dd9ab2564a70bc7f01530e4d6445153f77e1
Gerrit-Change-Number: 12499
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 16:22:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "Update toolchain to support ubuntu 18.04"

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/12499 )

Change subject: Revert "Update toolchain to support ubuntu 18.04"
......................................................................


Abandoned

Builds now
-- 
To view, visit http://gerrit.cloudera.org:8080/12499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib8b9dd9ab2564a70bc7f01530e4d6445153f77e1
Gerrit-Change-Number: 12499
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>

[Impala-ASF-CR] Revert "Update toolchain to support ubuntu 18.04"

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12499 )

Change subject: Revert "Update toolchain to support ubuntu 18.04"
......................................................................


Patch Set 1: Code-Review+1

I checked the S3 bucket too: the binary tarballs for Ubuntu14 are not there. I recall that the toolchain changes for supporting Ubuntu18 actually contain code that builds those bits for Ubuntu14 (https://gerrit.cloudera.org/c/12285/ and https://gerrit.cloudera.org/c/12286/), so I assume this was just a local build that went bad.
IMPALA-7273 says we still support Ubuntu 14 with toolchain bits, so let's fix that first in the toolchain, then we can revive this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/12499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b9dd9ab2564a70bc7f01530e4d6445153f77e1
Gerrit-Change-Number: 12499
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 14:48:34 +0000
Gerrit-HasComments: No