You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/06 12:49:39 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28765: Move impersonation tests out of Quarantine
potiuk opened a new pull request, #28765:
URL: https://github.com/apache/airflow/pull/28765
After #28378 where the tests were converted to Pytest we have high hopes those changed could remove flakiness from those tests.
We are gradually removing the tests out of quarantine to see whether they are not flaky now (and whether they are not contageous any more and do not create side-effects for other tests.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28765:
URL: https://github.com/apache/airflow/pull/28765#issuecomment-1373583153
I will run this one couple of times (added full-tests-needed now to increase the likelihood of the flaky behaviour/side-effect occurence) - I will also later run them using public runners to see if the effect are not occuring there (also with "full-tests-needed").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28765:
URL: https://github.com/apache/airflow/pull/28765#issuecomment-1373711542
Oh... miss this PR and create almost the same: #28767 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28765:
URL: https://github.com/apache/airflow/pull/28765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28765:
URL: https://github.com/apache/airflow/pull/28765#issuecomment-1374412427
All Good. I think those are stable and we can merge them @Taragolis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28765:
URL: https://github.com/apache/airflow/pull/28765#issuecomment-1373726539
OK. I am re-running it now with public runners + full tests. Let's see if it will be as stable :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #28765: Move impersonation tests out of Quarantine
URL: https://github.com/apache/airflow/pull/28765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28765:
URL: https://github.com/apache/airflow/pull/28765#issuecomment-1373722764
(BTW. So far impersonation tests run cool - except occassional other failures, there were so far two full test sets with no failures).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28765:
URL: https://github.com/apache/airflow/pull/28765#issuecomment-1373726925
Reopended with "use public runners".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #28765: Move impersonation tests out of Quarantine
URL: https://github.com/apache/airflow/pull/28765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28765:
URL: https://github.com/apache/airflow/pull/28765#issuecomment-1373679117
Only Helm test failed once - re-opened to rebuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28765:
URL: https://github.com/apache/airflow/pull/28765#issuecomment-1373721626
> Oh... miss this PR and create almost the same: #28767 🤣
As discussed there - we might merge this one first, then rebase the other after a day/two of running PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #28765: Move impersonation tests out of Quarantine
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #28765: Move impersonation tests out of Quarantine
URL: https://github.com/apache/airflow/pull/28765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org