[jira] [Commented] (GEODE-5134) RegionMap tx methods should expect the pendingCallbacks parameter to never be null

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456722#comment-16456722 ] 

ASF subversion and git services commented on GEODE-5134:
--------------------------------------------------------

Commit fafaf0b454f96662d41c589b278afedd26e9312b in geode's branch refs/heads/develop from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fafaf0b ]

GEODE-5134: pendingCallbacks is never null (#1863)

The tx* method implementations now always expect the pendingCallbacks parameter to not be null.
Also "cb" was renamed to "callback" for clarity.



> RegionMap tx methods should expect the pendingCallbacks parameter to never be null
> ----------------------------------------------------------------------------------
>
>                 Key: GEODE-5134
>                 URL: https://issues.apache.org/jira/browse/GEODE-5134
>             Project: Geode
>          Issue Type: Improvement
>          Components: transactions
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> All the tx* methods on RegionMap (txApplyPut, txApplyInvalidate, txApplyDestroy) have a pendingCallbacks parameter. All the implementations of these methods have special code that handles pendingCallbacks being null. But the callers have been changed to never pass a null pendingCallbacks.
> Changing these methods to only handle a non-null pendingCallbacks will make these methods easier to understand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)