You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Fabriceli (via GitHub)" <gi...@apache.org> on 2023/08/04 16:03:31 UTC
[GitHub] [apisix] Fabriceli opened a new pull request, #9971: doc: add more details for consumer-restriction plugin
Fabriceli opened a new pull request, #9971:
URL: https://github.com/apache/apisix/pull/9971
### Description
1. add more details about `allowed_by_methods` include `allowed_by_methods.user` and `allowed_by_methods.methods` in zh doc
2. add more details about `allowed_by_methods` include `allowed_by_methods.user` and `allowed_by_methods.methods` in en doc
Fixes # (issue)
#9873
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
3. Always add/update tests for any changes unless you have a good reason.
4. Always update the documentation to reflect the changes made in the PR.
5. Make a new commit to resolve conversations instead of `push -f`.
6. To resolve merge conflicts, merge master instead of rebasing.
7. Use "request review" to notify the reviewer after making changes.
8. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9971: docs: add more details for consumer-restriction plugin
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9971:
URL: https://github.com/apache/apisix/pull/9971#discussion_r1285354030
##########
docs/zh/latest/plugins/consumer-restriction.md:
##########
@@ -1,12 +1,6 @@
---
-title: consumer-restriction
-keywords:
- - Apache APISIX
- - API 网关
- - Consumer restriction
-description: Consumer Restriction 插件允许用户根据 Route、Service 或 Consumer 来设置相应的访问限制。
+span
Review Comment:
@kayx23 please help to check this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 merged pull request #9971: docs: add more details for consumer-restriction plugin
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #9971:
URL: https://github.com/apache/apisix/pull/9971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Fabriceli commented on a diff in pull request #9971: docs: add more details for consumer-restriction plugin
Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on code in PR #9971:
URL: https://github.com/apache/apisix/pull/9971#discussion_r1285931111
##########
docs/zh/latest/plugins/consumer-restriction.md:
##########
@@ -1,12 +1,6 @@
---
-title: consumer-restriction
-keywords:
- - Apache APISIX
- - API 网关
- - Consumer restriction
-description: Consumer Restriction 插件允许用户根据 Route、Service 或 Consumer 来设置相应的访问限制。
+span
Review Comment:
markdownlint delete by mistake.
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9971: docs: add more details for consumer-restriction plugin
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9971:
URL: https://github.com/apache/apisix/pull/9971#discussion_r1285353178
##########
docs/zh/latest/plugins/consumer-restriction.md:
##########
@@ -1,12 +1,6 @@
---
-title: consumer-restriction
-keywords:
- - Apache APISIX
- - API 网关
- - Consumer restriction
-description: Consumer Restriction 插件允许用户根据 Route、Service 或 Consumer 来设置相应的访问限制。
+span
Review Comment:
Why do you remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Fabriceli commented on pull request #9971: docs: add more details for consumer-restriction plugin
Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #9971:
URL: https://github.com/apache/apisix/pull/9971#issuecomment-1666414977
@jiangfucheng @shreemaan-abhishek pls take a look at this PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Fabriceli commented on pull request #9971: docs: add more details for consumer-restriction plugin
Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #9971:
URL: https://github.com/apache/apisix/pull/9971#issuecomment-1666868060
@monkeyDluffy6017 pls take a look at this PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org