[GitHub] [spark] wangyum commented on a change in pull request #27252: [SPARK-29231][SQL] Constraints should be inferred from cast equality constraint

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #27252: [SPARK-29231][SQL] Constraints should be inferred from cast equality constraint
URL: https://github.com/apache/spark/pull/27252#discussion_r374458278
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
 ##########
 @@ -62,11 +62,16 @@ trait ConstraintHelper {
    */
   def inferAdditionalConstraints(constraints: Set[Expression]): Set[Expression] = {
     var inferredConstraints = Set.empty[Expression]
+    val binaryComparisons = constraints.filter(_.isInstanceOf[BinaryComparison])
 
 Review comment:
   The issue fix by https://github.com/apache/spark/pull/27252/commits/420058bf35371ddb49c67ff3c893add3281aeba9.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org