[GitHub] [hadoop] steveloughran commented on pull request #4869: HADOOP-18444 Add Support for localized trash for ViewFileSystem in Trash.moveToAppropriateTrash

[GitBox <gi...@apache.org>]

steveloughran commented on PR #4869:
URL: https://github.com/apache/hadoop/pull/4869#issuecomment-1242273564

   interesting. In #4729 i'm proposing the ability to choose a trash policy for different fs fschemas, so the one for viewfs could be different to hdfs and then from abfs and s3a. The changes are handling the actual rename/delete checkpoint stuff, but not the changes you are proposing into Trash.
   
   having Trash choose its policy based on instanceof values is a bad path to follow.
   
   I'd be happier if the decision was done in a viewfs specific trash policy. Would there be a way to add the extra methods needed for the policy itself -the existing plugin point- to handle the viewfs details?
   
   That could maybe also line up with having the stores use the same extension points if they want to be extra clever. Not sure what they would want to do; the work I'm adding is to address these problems
   
   * ability to turn off trash on versioned s3a (no attempt to be adaptive)
   * gcs & abfs: some extra resilience, stats collection if FS does it, and the option to have a moveToTrash() operation include an -expunge of old checkpoints. That's to stop the stores collecting too much old data that's never cleaned up.
   
   I'm away for a week, back sept 19. if you looked at my PR and especially the schema-specific plugin, would that work if you added the trash root awareness to the policy? if so, you could take that bit of the PR and run with it, as you are ahead of me and my work.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org