You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/23 05:31:38 UTC

[GitHub] [incubator-dolphinscheduler] zjcnb opened a new pull request #1541: remove duplicated code

zjcnb opened a new pull request #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541
 
 
   remove duplicated code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568362050
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=h1) Report
   > Merging [#1541](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/15a402a3f20253e5c46f9b833aff91c851e002a4?src=pr&el=desc) will **increase** coverage by `0.51%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1541      +/-   ##
   ========================================
   + Coverage    7.4%   7.91%   +0.51%     
   ========================================
     Files        272     280       +8     
     Lines      13634   13814     +180     
     Branches    2169    2198      +29     
   ========================================
   + Hits        1010    1094      +84     
   - Misses     12557   12646      +89     
   - Partials      67      74       +7
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/dao/entity/Alert.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BbGVydC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...apache/dolphinscheduler/dao/entity/AlertGroup.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BbGVydEdyb3VwLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...rg/apache/dolphinscheduler/dao/entity/Command.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Db21tYW5kLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...ache/dolphinscheduler/dao/entity/CommandCount.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Db21tYW5kQ291bnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (-15.24%)` | :arrow_down: |
   | [...phinscheduler/api/configuration/SwaggerConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU3dhZ2dlckNvbmZpZy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/server/zk/ZKWorkerClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3prL1pLV29ya2VyQ2xpZW50LmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/api/ApiApplicationServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL0FwaUFwcGxpY2F0aW9uU2VydmVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...ler/server/master/runner/MasterTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyVGFza0V4ZWNUaHJlYWQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...onfiguration/ServiceModelToSwagger2MapperImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU2VydmljZU1vZGVsVG9Td2FnZ2VyMk1hcHBlckltcGwuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=footer). Last update [15a402a...5d7fddf](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568418553
 
 
   > > > how about keeping the code the same ?
   > > > like : add TableField in Alert class
   > > 
   > > 
   > > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project
   > 
   > why did you keep it in AccessToken? I think we should keep the same manager .
   
   this project has @TableField annotation  already， I didn't add it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-569634977
 
 
   @zjcnb ,  hello,  could you submit another pr,  for now, this pr has conflicted with DS,   if you submit a new   
   pr, please remember  removing @DaTa ,  We have always wanted to reduce third-party dependence. 
   
   thanks you for your contribution again

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568755894
 
 
   > > > > > > how about keeping the code the same ?
   > > > > > > like : add TableField in Alert class
   > > > > > 
   > > > > > 
   > > > > > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project
   > > > > 
   > > > > 
   > > > > why did you keep it in AccessToken? I think we should keep the same manager .
   > > > 
   > > > 
   > > > this project has @TableField annotation already， I didn't add it
   > > 
   > > 
   > > I mean : try to add @TableField in Alert class to keep code in the same style.
   > 
   > ok!
   
   Hi, bro,  did you need any help ? you can send me a email

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568362050
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=h1) Report
   > Merging [#1541](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/15a402a3f20253e5c46f9b833aff91c851e002a4?src=pr&el=desc) will **increase** coverage by `0.51%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1541      +/-   ##
   ========================================
   + Coverage    7.4%   7.91%   +0.51%     
   ========================================
     Files        272     280       +8     
     Lines      13634   13814     +180     
     Branches    2169    2198      +29     
   ========================================
   + Hits        1010    1094      +84     
   - Misses     12557   12646      +89     
   - Partials      67      74       +7
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/dao/entity/Alert.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BbGVydC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...apache/dolphinscheduler/dao/entity/AlertGroup.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BbGVydEdyb3VwLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...rg/apache/dolphinscheduler/dao/entity/Command.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Db21tYW5kLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...ache/dolphinscheduler/dao/entity/CommandCount.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Db21tYW5kQ291bnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (-15.24%)` | :arrow_down: |
   | [...phinscheduler/api/configuration/SwaggerConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU3dhZ2dlckNvbmZpZy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/server/zk/ZKWorkerClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3prL1pLV29ya2VyQ2xpZW50LmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/api/ApiApplicationServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL0FwaUFwcGxpY2F0aW9uU2VydmVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...ler/server/master/runner/MasterTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyVGFza0V4ZWNUaHJlYWQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...onfiguration/ServiceModelToSwagger2MapperImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU2VydmljZU1vZGVsVG9Td2FnZ2VyMk1hcHBlckltcGwuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=footer). Last update [15a402a...5d7fddf](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568417376
 
 
   > > how about keeping the code the same ?
   > > like : add TableField in Alert class
   > 
   > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project
   
   why did you keep it in AccessToken?  I think we should keep the same manager .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568419069
 
 
   > > > > how about keeping the code the same ?
   > > > > like : add TableField in Alert class
   > > > 
   > > > 
   > > > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project
   > > 
   > > 
   > > why did you keep it in AccessToken? I think we should keep the same manager .
   > 
   > this project has @TableField annotation already， I didn't add it
   
   I mean : try to add @TableField in Alert class to keep code in the same style.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- edited a comment on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
Technoboy- edited a comment on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568755894
 
 
   > > > > > > how about keeping the code the same ?
   > > > > > > like : add TableField in Alert class
   > > > > > 
   > > > > > 
   > > > > > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project
   > > > > 
   > > > > 
   > > > > why did you keep it in AccessToken? I think we should keep the same manager .
   > > > 
   > > > 
   > > > this project has @TableField annotation already， I didn't add it
   > > 
   > > 
   > > I mean : try to add @TableField in Alert class to keep code in the same style.
   > 
   > ok!
   
   Hi, bro,  did you need any help ? you can send me an email

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
dailidong closed pull request #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568849254
 
 
   Hi bro, as we discuss, we want to remove lombok dependancy , so try to remove @Data annotation 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568419423
 
 
   > > > > > how about keeping the code the same ?
   > > > > > like : add TableField in Alert class
   > > > > 
   > > > > 
   > > > > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project
   > > > 
   > > > 
   > > > why did you keep it in AccessToken? I think we should keep the same manager .
   > > 
   > > 
   > > this project has @TableField annotation already， I didn't add it
   > 
   > I mean : try to add @TableField in Alert class to keep code in the same style.
   
   ok!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568362050
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=h1) Report
   > Merging [#1541](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/15a402a3f20253e5c46f9b833aff91c851e002a4?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1541      +/-   ##
   ========================================
   + Coverage    7.4%   7.42%   +0.01%     
   ========================================
     Files        272     272              
     Lines      13634   13629       -5     
     Branches    2169    2170       +1     
   ========================================
   + Hits        1010    1012       +2     
   + Misses     12557   12550       -7     
     Partials      67      67
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...pache/dolphinscheduler/dao/entity/AccessToken.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BY2Nlc3NUb2tlbi5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [.../org/apache/dolphinscheduler/dao/entity/Alert.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BbGVydC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...ache/dolphinscheduler/dao/entity/CommandCount.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Db21tYW5kQ291bnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...ache/dolphinscheduler/common/enums/ZKNodeType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1pLTm9kZVR5cGUuamF2YQ==) | `100% <0%> (+100%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=footer). Last update [15a402a...8f64d42](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1541?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1541: remove duplicated code

Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #1541: remove duplicated code
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568408410
 
 
   > how about keeping the code the same ?
   > like : add TableField in Alert class
   
   I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services