You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/02/10 13:03:39 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #6802: Core: Fix field-id from Avro converted schema
Fokko opened a new pull request, #6802:
URL: https://github.com/apache/iceberg/pull/6802
It started by 0, but that led to incorrect results. Also, when a table is created, it also starts at 1. So this seems to be an inconsistency.
Resolves #6796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #6802: Core: Fix field-id from Avro converted schema
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #6802:
URL: https://github.com/apache/iceberg/pull/6802#issuecomment-1426350972
@rdblue ah, I see also the problem now and I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko closed pull request #6802: Core: Fix field-id from Avro converted schema
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed pull request #6802: Core: Fix field-id from Avro converted schema
URL: https://github.com/apache/iceberg/pull/6802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #6802: Core: Fix field-id from Avro converted schema
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on PR #6802:
URL: https://github.com/apache/iceberg/pull/6802#issuecomment-1426201751
I'm -1 on this change. I think that we want failures like #6796.
When writing to a table, **you must always write using the table's schema**. You can't guess at what the schema will be or how the field IDs are probably assigned. It is always incorrect to create a table, create an Avro schema independently, and then use that Avro schema, even if it works in some cases because assignment is the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org