You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2008/10/09 19:36:44 UTC

[jira] Created: (LUCENE-1416) Ant contrib test can fail if there is a space in path to lucene project

Ant contrib test can fail if there is a space in path to lucene project
-----------------------------------------------------------------------

                 Key: LUCENE-1416
                 URL: https://issues.apache.org/jira/browse/LUCENE-1416
             Project: Lucene - Java
          Issue Type: Bug
          Components: contrib/*
            Reporter: Mark Miller
            Priority: Trivial


A couple contrib ant tests get the path to test files through a URL object, and so the path is URL encoded. Normally fine, but if you have a space in your path (/svn stuff/lucene/contrib/ant) then it will have %20 for the space and (at least on my Ubuntu system) the test will fail with filenotfound. This patch simply replaces all %20 with " ". Not sure if we want/need to take it any further.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1416) Ant contrib test can fail if there is a space in path to lucene project

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated LUCENE-1416:
--------------------------------

    Attachment: LUCENE-1416.patch

Patch using URLDecoder

> Ant contrib test can fail if there is a space in path to lucene project
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-1416
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1416
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>            Reporter: Mark Miller
>            Priority: Trivial
>         Attachments: LUCENE-1416.patch, LUCENE-1416.patch
>
>
> A couple contrib ant tests get the path to test files through a URL object, and so the path is URL encoded. Normally fine, but if you have a space in your path (/svn stuff/lucene/contrib/ant) then it will have %20 for the space and (at least on my Ubuntu system) the test will fail with filenotfound. This patch simply replaces all %20 with " ". Not sure if we want/need to take it any further.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1416) Ant contrib test can fail if there is a space in path to lucene project

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated LUCENE-1416:
--------------------------------

    Attachment: LUCENE-1416.patch

> Ant contrib test can fail if there is a space in path to lucene project
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-1416
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1416
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>            Reporter: Mark Miller
>            Priority: Trivial
>         Attachments: LUCENE-1416.patch
>
>
> A couple contrib ant tests get the path to test files through a URL object, and so the path is URL encoded. Normally fine, but if you have a space in your path (/svn stuff/lucene/contrib/ant) then it will have %20 for the space and (at least on my Ubuntu system) the test will fail with filenotfound. This patch simply replaces all %20 with " ". Not sure if we want/need to take it any further.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1416) Ant contrib test can fail if there is a space in path to lucene project

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1416.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.9
         Assignee: Michael McCandless
    Lucene Fields: [New, Patch Available]  (was: [Patch Available, New])

Thank Mark, I just committed this!

> Ant contrib test can fail if there is a space in path to lucene project
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-1416
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1416
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>            Reporter: Mark Miller
>            Assignee: Michael McCandless
>            Priority: Trivial
>             Fix For: 2.9
>
>         Attachments: LUCENE-1416.patch, LUCENE-1416.patch
>
>
> A couple contrib ant tests get the path to test files through a URL object, and so the path is URL encoded. Normally fine, but if you have a space in your path (/svn stuff/lucene/contrib/ant) then it will have %20 for the space and (at least on my Ubuntu system) the test will fail with filenotfound. This patch simply replaces all %20 with " ". Not sure if we want/need to take it any further.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1416) Ant contrib test can fail if there is a space in path to lucene project

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639777#action_12639777 ] 

Michael McCandless commented on LUCENE-1416:
--------------------------------------------

Is there a more generic function that can un-escape a URL-encoded string?  Space/%20 seems like the most common problem, but other characters are escaped in URLs too.

> Ant contrib test can fail if there is a space in path to lucene project
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-1416
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1416
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>            Reporter: Mark Miller
>            Priority: Trivial
>         Attachments: LUCENE-1416.patch
>
>
> A couple contrib ant tests get the path to test files through a URL object, and so the path is URL encoded. Normally fine, but if you have a space in your path (/svn stuff/lucene/contrib/ant) then it will have %20 for the space and (at least on my Ubuntu system) the test will fail with filenotfound. This patch simply replaces all %20 with " ". Not sure if we want/need to take it any further.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1416) Ant contrib test can fail if there is a space in path to lucene project

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639792#action_12639792 ] 

Mark Miller commented on LUCENE-1416:
-------------------------------------

Yeah, thats why I mention we might want to take it further. Just wasn't 
sure if another char was actually a problem. We can use URLDecoder to 
hit everything though right? I'll put up a new patch when I get a chance.


> Ant contrib test can fail if there is a space in path to lucene project
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-1416
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1416
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>            Reporter: Mark Miller
>            Priority: Trivial
>         Attachments: LUCENE-1416.patch
>
>
> A couple contrib ant tests get the path to test files through a URL object, and so the path is URL encoded. Normally fine, but if you have a space in your path (/svn stuff/lucene/contrib/ant) then it will have %20 for the space and (at least on my Ubuntu system) the test will fail with filenotfound. This patch simply replaces all %20 with " ". Not sure if we want/need to take it any further.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org