You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by Alasdair Nottingham <no...@apache.org> on 2011/01/11 22:31:21 UTC
Re: svn commit: r1057705 - in /aries/branches/0.3-RCx/samples:
ariestrader/modules/ariestrader-web/pom.xml blog/blog-web/pom.xml
Hi,
This is a really bad change to make. It essentially means that the
class files will be served up. The web extender should not require the
content to be available on the classpath. Did you make this change to
get the static content served? If so I'll raise another bug against
pax-web.
On 11 January 2011 15:51, <jb...@apache.org> wrote:
> Author: jbohn
> Date: Tue Jan 11 15:51:16 2011
> New Revision: 1057705
>
> URL: http://svn.apache.org/viewvc?rev=1057705&view=rev
> Log:
> merge 1057701 from trunk
>
> Modified:
> aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
> aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
>
> Modified: aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
> ==============================================================================
> --- aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml (original)
> +++ aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml Tue Jan 11 15:51:16 2011
> @@ -70,6 +70,7 @@
> <instructions>
> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
> <Bundle-Version>${pom.version}</Bundle-Version>
> + <Bundle-ClassPath>.</Bundle-ClassPath>
> <Web-ContextPath>/ariestrader</Web-ContextPath>
> <Web-JSPExtractLocation>/</Web-JSPExtractLocation>
> <Private-Package>org.apache.aries.samples.ariestrader.web.*</Private-Package>
>
> Modified: aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
> ==============================================================================
> --- aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml (original)
> +++ aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml Tue Jan 11 15:51:16 2011
> @@ -50,6 +50,7 @@
> <instructions>
> <Web-ContextPath>/blog</Web-ContextPath>
> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
> + <Bundle-ClassPath>.</Bundle-ClassPath>
> <Private-Package>org.apache.aries.samples.blog.web.*</Private-Package>
> <Export-Package>!org.apache.aries.samples.blog.web.*</Export-Package>
> <Import-Package>
>
>
>
--
Alasdair Nottingham
not@apache.org
Re: svn commit: r1057705 - in /aries/branches/0.3-RCx/samples: ariestrader/modules/ariestrader-web/pom.xml
blog/blog-web/pom.xml
Posted by Joe Bohn <jo...@gmail.com>.
Sounds reasonable to me.
Joe
On 1/11/11 5:46 PM, Alasdair Nottingham wrote:
> It looks like pax web 0.8.1 correctly serves content without it
> needing to be on the classpath.
>
> I propose we move to 0.8.1 rather than 0.7.2 and don't add . onto the classpath.
>
> What do you think?
> Alasdair
>
> On 11 January 2011 22:22, Alasdair Nottingham<no...@apache.org> wrote:
>> You are right about the spec and WEB-INF, but they didn't implement the WAB spec properly so who knows, but it looks like we should be safe.
>>
>> Alasdair Nottingham
>>
>> On 11 Jan 2011, at 22:09, Joe Bohn<jo...@gmail.com> wrote:
>>
>>> Yes, that is correct. I found that I had to do this to get the static content served. After your changes to create of the web bundles the bundle-classpath was added to the manifest and static content was no longer served. I didn't think this would serve up the class files as I thought that a spec compliant implementation would not serve any static content from WEB-INF/.
>>>
>>> Joe
>>>
>>> On 1/11/11 4:31 PM, Alasdair Nottingham wrote:
>>>> Hi,
>>>>
>>>> This is a really bad change to make. It essentially means that the
>>>> class files will be served up. The web extender should not require the
>>>> content to be available on the classpath. Did you make this change to
>>>> get the static content served? If so I'll raise another bug against
>>>> pax-web.
>>>>
>>>> On 11 January 2011 15:51,<jb...@apache.org> wrote:
>>>>> Author: jbohn
>>>>> Date: Tue Jan 11 15:51:16 2011
>>>>> New Revision: 1057705
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1057705&view=rev
>>>>> Log:
>>>>> merge 1057701 from trunk
>>>>>
>>>>> Modified:
>>>>> aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
>>>>> aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
>>>>>
>>>>> Modified: aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
>>>>> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
>>>>> ==============================================================================
>>>>> --- aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml (original)
>>>>> +++ aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml Tue Jan 11 15:51:16 2011
>>>>> @@ -70,6 +70,7 @@
>>>>> <instructions>
>>>>> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
>>>>> <Bundle-Version>${pom.version}</Bundle-Version>
>>>>> +<Bundle-ClassPath>.</Bundle-ClassPath>
>>>>> <Web-ContextPath>/ariestrader</Web-ContextPath>
>>>>> <Web-JSPExtractLocation>/</Web-JSPExtractLocation>
>>>>> <Private-Package>org.apache.aries.samples.ariestrader.web.*</Private-Package>
>>>>>
>>>>> Modified: aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
>>>>> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
>>>>> ==============================================================================
>>>>> --- aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml (original)
>>>>> +++ aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml Tue Jan 11 15:51:16 2011
>>>>> @@ -50,6 +50,7 @@
>>>>> <instructions>
>>>>> <Web-ContextPath>/blog</Web-ContextPath>
>>>>> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
>>>>> +<Bundle-ClassPath>.</Bundle-ClassPath>
>>>>> <Private-Package>org.apache.aries.samples.blog.web.*</Private-Package>
>>>>> <Export-Package>!org.apache.aries.samples.blog.web.*</Export-Package>
>>>>> <Import-Package>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Joe
>>
>
>
>
--
Joe
Re: svn commit: r1057705 - in /aries/branches/0.3-RCx/samples:
ariestrader/modules/ariestrader-web/pom.xml blog/blog-web/pom.xml
Posted by Alasdair Nottingham <no...@apache.org>.
It looks like pax web 0.8.1 correctly serves content without it
needing to be on the classpath.
I propose we move to 0.8.1 rather than 0.7.2 and don't add . onto the classpath.
What do you think?
Alasdair
On 11 January 2011 22:22, Alasdair Nottingham <no...@apache.org> wrote:
> You are right about the spec and WEB-INF, but they didn't implement the WAB spec properly so who knows, but it looks like we should be safe.
>
> Alasdair Nottingham
>
> On 11 Jan 2011, at 22:09, Joe Bohn <jo...@gmail.com> wrote:
>
>> Yes, that is correct. I found that I had to do this to get the static content served. After your changes to create of the web bundles the bundle-classpath was added to the manifest and static content was no longer served. I didn't think this would serve up the class files as I thought that a spec compliant implementation would not serve any static content from WEB-INF/.
>>
>> Joe
>>
>> On 1/11/11 4:31 PM, Alasdair Nottingham wrote:
>>> Hi,
>>>
>>> This is a really bad change to make. It essentially means that the
>>> class files will be served up. The web extender should not require the
>>> content to be available on the classpath. Did you make this change to
>>> get the static content served? If so I'll raise another bug against
>>> pax-web.
>>>
>>> On 11 January 2011 15:51,<jb...@apache.org> wrote:
>>>> Author: jbohn
>>>> Date: Tue Jan 11 15:51:16 2011
>>>> New Revision: 1057705
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1057705&view=rev
>>>> Log:
>>>> merge 1057701 from trunk
>>>>
>>>> Modified:
>>>> aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
>>>> aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
>>>>
>>>> Modified: aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
>>>> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
>>>> ==============================================================================
>>>> --- aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml (original)
>>>> +++ aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml Tue Jan 11 15:51:16 2011
>>>> @@ -70,6 +70,7 @@
>>>> <instructions>
>>>> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
>>>> <Bundle-Version>${pom.version}</Bundle-Version>
>>>> +<Bundle-ClassPath>.</Bundle-ClassPath>
>>>> <Web-ContextPath>/ariestrader</Web-ContextPath>
>>>> <Web-JSPExtractLocation>/</Web-JSPExtractLocation>
>>>> <Private-Package>org.apache.aries.samples.ariestrader.web.*</Private-Package>
>>>>
>>>> Modified: aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
>>>> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
>>>> ==============================================================================
>>>> --- aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml (original)
>>>> +++ aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml Tue Jan 11 15:51:16 2011
>>>> @@ -50,6 +50,7 @@
>>>> <instructions>
>>>> <Web-ContextPath>/blog</Web-ContextPath>
>>>> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
>>>> +<Bundle-ClassPath>.</Bundle-ClassPath>
>>>> <Private-Package>org.apache.aries.samples.blog.web.*</Private-Package>
>>>> <Export-Package>!org.apache.aries.samples.blog.web.*</Export-Package>
>>>> <Import-Package>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>>
>> --
>> Joe
>
--
Alasdair Nottingham
not@apache.org
Re: svn commit: r1057705 - in /aries/branches/0.3-RCx/samples: ariestrader/modules/ariestrader-web/pom.xml blog/blog-web/pom.xml
Posted by Alasdair Nottingham <no...@apache.org>.
You are right about the spec and WEB-INF, but they didn't implement the WAB spec properly so who knows, but it looks like we should be safe.
Alasdair Nottingham
On 11 Jan 2011, at 22:09, Joe Bohn <jo...@gmail.com> wrote:
> Yes, that is correct. I found that I had to do this to get the static content served. After your changes to create of the web bundles the bundle-classpath was added to the manifest and static content was no longer served. I didn't think this would serve up the class files as I thought that a spec compliant implementation would not serve any static content from WEB-INF/.
>
> Joe
>
> On 1/11/11 4:31 PM, Alasdair Nottingham wrote:
>> Hi,
>>
>> This is a really bad change to make. It essentially means that the
>> class files will be served up. The web extender should not require the
>> content to be available on the classpath. Did you make this change to
>> get the static content served? If so I'll raise another bug against
>> pax-web.
>>
>> On 11 January 2011 15:51,<jb...@apache.org> wrote:
>>> Author: jbohn
>>> Date: Tue Jan 11 15:51:16 2011
>>> New Revision: 1057705
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1057705&view=rev
>>> Log:
>>> merge 1057701 from trunk
>>>
>>> Modified:
>>> aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
>>> aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
>>>
>>> Modified: aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
>>> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
>>> ==============================================================================
>>> --- aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml (original)
>>> +++ aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml Tue Jan 11 15:51:16 2011
>>> @@ -70,6 +70,7 @@
>>> <instructions>
>>> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
>>> <Bundle-Version>${pom.version}</Bundle-Version>
>>> +<Bundle-ClassPath>.</Bundle-ClassPath>
>>> <Web-ContextPath>/ariestrader</Web-ContextPath>
>>> <Web-JSPExtractLocation>/</Web-JSPExtractLocation>
>>> <Private-Package>org.apache.aries.samples.ariestrader.web.*</Private-Package>
>>>
>>> Modified: aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
>>> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
>>> ==============================================================================
>>> --- aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml (original)
>>> +++ aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml Tue Jan 11 15:51:16 2011
>>> @@ -50,6 +50,7 @@
>>> <instructions>
>>> <Web-ContextPath>/blog</Web-ContextPath>
>>> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
>>> +<Bundle-ClassPath>.</Bundle-ClassPath>
>>> <Private-Package>org.apache.aries.samples.blog.web.*</Private-Package>
>>> <Export-Package>!org.apache.aries.samples.blog.web.*</Export-Package>
>>> <Import-Package>
>>>
>>>
>>>
>>
>>
>>
>
>
> --
> Joe
Re: svn commit: r1057705 - in /aries/branches/0.3-RCx/samples: ariestrader/modules/ariestrader-web/pom.xml
blog/blog-web/pom.xml
Posted by Joe Bohn <jo...@gmail.com>.
Yes, that is correct. I found that I had to do this to get the static
content served. After your changes to create of the web bundles the
bundle-classpath was added to the manifest and static content was no
longer served. I didn't think this would serve up the class files as I
thought that a spec compliant implementation would not serve any static
content from WEB-INF/.
Joe
On 1/11/11 4:31 PM, Alasdair Nottingham wrote:
> Hi,
>
> This is a really bad change to make. It essentially means that the
> class files will be served up. The web extender should not require the
> content to be available on the classpath. Did you make this change to
> get the static content served? If so I'll raise another bug against
> pax-web.
>
> On 11 January 2011 15:51,<jb...@apache.org> wrote:
>> Author: jbohn
>> Date: Tue Jan 11 15:51:16 2011
>> New Revision: 1057705
>>
>> URL: http://svn.apache.org/viewvc?rev=1057705&view=rev
>> Log:
>> merge 1057701 from trunk
>>
>> Modified:
>> aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
>> aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
>>
>> Modified: aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml
>> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
>> ==============================================================================
>> --- aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml (original)
>> +++ aries/branches/0.3-RCx/samples/ariestrader/modules/ariestrader-web/pom.xml Tue Jan 11 15:51:16 2011
>> @@ -70,6 +70,7 @@
>> <instructions>
>> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
>> <Bundle-Version>${pom.version}</Bundle-Version>
>> +<Bundle-ClassPath>.</Bundle-ClassPath>
>> <Web-ContextPath>/ariestrader</Web-ContextPath>
>> <Web-JSPExtractLocation>/</Web-JSPExtractLocation>
>> <Private-Package>org.apache.aries.samples.ariestrader.web.*</Private-Package>
>>
>> Modified: aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml
>> URL: http://svn.apache.org/viewvc/aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml?rev=1057705&r1=1057704&r2=1057705&view=diff
>> ==============================================================================
>> --- aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml (original)
>> +++ aries/branches/0.3-RCx/samples/blog/blog-web/pom.xml Tue Jan 11 15:51:16 2011
>> @@ -50,6 +50,7 @@
>> <instructions>
>> <Web-ContextPath>/blog</Web-ContextPath>
>> <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
>> +<Bundle-ClassPath>.</Bundle-ClassPath>
>> <Private-Package>org.apache.aries.samples.blog.web.*</Private-Package>
>> <Export-Package>!org.apache.aries.samples.blog.web.*</Export-Package>
>> <Import-Package>
>>
>>
>>
>
>
>
--
Joe