You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/30 11:36:44 UTC
[GitHub] [flink] zentol opened a new pull request #10974:
[FLINK-15807][docs] Add Java 11 to supported JDKs
zentol opened a new pull request #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974
Adds Java 11 to the set of supported JDKs.
Note that certain features (cassandra, hive, hbase, kafka 0.X) may not work on Java 11, but I don't know whether this is due to an incompatibility in our connector or the external server (the more likely). Hence I opted to not document this, on the assumption that users will run their stuff on a single Java version, and if they have Java 11 with a working cassandra server then the connector will likely work as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL edited a comment on issue #10974: [FLINK-15807][docs]
Add Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
GJL edited a comment on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580631491
> Meanwhile, if we're going to announce java 11 support in 1.10.0 release, hopefully somewhere we could remind our users that certain source/sink (cassandra/hbase/hive/old-version-kafka) don't support java 11 yet,
I don't understand what we want to document in the release notes exactly. The description of the PR says that we do not fully understand why some connectors don't work. I am against documenting things that we don't understand ourselves.
(edited)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10974: [FLINK-15807][docs] Add
Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10974:
[FLINK-15807][docs] Add Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580223272
<!--
Meta data
Hash:b1976695c7d51149a670294b7752142cc36a746a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146742895 TriggerType:PUSH TriggerID:b1976695c7d51149a670294b7752142cc36a746a
Hash:b1976695c7d51149a670294b7752142cc36a746a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4678 TriggerType:PUSH TriggerID:b1976695c7d51149a670294b7752142cc36a746a
-->
## CI report:
* b1976695c7d51149a670294b7752142cc36a746a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146742895) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4678)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL edited a comment on issue #10974: [FLINK-15807][docs]
Add Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
GJL edited a comment on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580631491
> Meanwhile, if we're going to announce java 11 support in 1.10.0 release, hopefully somewhere we could remind our users that certain source/sink (cassandra/hbase/hive/old-version-kafka) don't support java 11 yet,
I don't understand what we want to document in the release notes exactly. The description of the PR says that we do not fully understand why some connectors don't work. Can we try out all connectors on JDK11? I am against documenting things that we don't understand ourselves.
(edited)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol edited a comment on issue #10974:
[FLINK-15807][docs] Add Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580711814
What is listed in the PR description (Cassandra, Hive, HBase, Kafka 0.8-0.11). These are the features for which we have tests that are not being run on Java 11. We also have no e2e runs on YARN, but the IT cases are passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10974:
[FLINK-15807][docs] Add Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580223272
<!--
Meta data
Hash:b1976695c7d51149a670294b7752142cc36a746a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146742895 TriggerType:PUSH TriggerID:b1976695c7d51149a670294b7752142cc36a746a
Hash:b1976695c7d51149a670294b7752142cc36a746a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4678 TriggerType:PUSH TriggerID:b1976695c7d51149a670294b7752142cc36a746a
-->
## CI report:
* b1976695c7d51149a670294b7752142cc36a746a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146742895) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4678)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10974: [FLINK-15807][docs] Add Java
11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580696746
I am ok with saying that we haven't tested some connectors. Is there a list of untested connectors or should we just say all of them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on issue #10974: [FLINK-15807][docs] Add
Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
carp84 commented on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-581760713
> What is listed in the PR description (Cassandra, Hive, HBase, Kafka 0.8-0.11). These are the features for which we have tests that are not being run on Java 11. We also have no e2e runs on YARN, but the IT cases are passing.
I could see this already tracked by #10997 , so it seems the PR here is ready to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10974: [FLINK-15807][docs] Add
Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580223272
<!--
Meta data
Hash:b1976695c7d51149a670294b7752142cc36a746a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b1976695c7d51149a670294b7752142cc36a746a
-->
## CI report:
* b1976695c7d51149a670294b7752142cc36a746a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol edited a comment on issue #10974:
[FLINK-15807][docs] Add Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580711814
What is listed in the PR description (Cassandra, Hive, HBase, Kafka 0.8-0.11), and YARN. These are the features for which we have tests that are not being run on Java 11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #10974: [FLINK-15807][docs] Add
Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580666486
We could document that we haven't tested these features on Java 11, since the backing library does not officially support Java 11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10974:
[FLINK-15807][docs] Add Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580223272
<!--
Meta data
Hash:b1976695c7d51149a670294b7752142cc36a746a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146742895 TriggerType:PUSH TriggerID:b1976695c7d51149a670294b7752142cc36a746a
Hash:b1976695c7d51149a670294b7752142cc36a746a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4678 TriggerType:PUSH TriggerID:b1976695c7d51149a670294b7752142cc36a746a
-->
## CI report:
* b1976695c7d51149a670294b7752142cc36a746a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146742895) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4678)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10974: [FLINK-15807][docs] Add
Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580213913
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b1976695c7d51149a670294b7752142cc36a746a (Thu Jan 30 11:39:49 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #10974: [FLINK-15807][docs] Add
Java 11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580711814
What is listed in the PR description (Cassandra, Hive, HBase, Kafka 0.8-0.11), and YARN. These are the features for which we have tests that are not running on Java 11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10974: [FLINK-15807][docs] Add Java
11 to supported JDKs
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10974: [FLINK-15807][docs] Add Java 11 to supported JDKs
URL: https://github.com/apache/flink/pull/10974#issuecomment-580631491
> Meanwhile, if we're going to announce java 11 support in 1.10.0 release, hopefully somewhere we could remind our users that certain source/sink (cassandra/hbase/hive/old-version-kafka) don't support java 11 yet,
I don't understand what we want to document exactly. The description of the PR says that we do not fully understand why some connectors don't work. I am against documenting things that we don't understand ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services