You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by mi...@apache.org on 2023/03/22 14:48:19 UTC

[impala] branch master updated: IMPALA-12013: Remove future from pkg_resources.py

This is an automated email from the ASF dual-hosted git repository.

michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 8f204c82b IMPALA-12013: Remove future from pkg_resources.py
8f204c82b is described below

commit 8f204c82b74c7eccfe7d921a916ec36c0785cfe7
Author: Michael Smith <mi...@cloudera.com>
AuthorDate: Tue Mar 21 10:43:49 2023 -0700

    IMPALA-12013: Remove future from pkg_resources.py
    
    Removes import future from pkg_resources.py as this file is fairly old
    and only used with Python 2. Adding unicode_literals in IMPALA-3343 /
    IMPALA-9489 broke reading files in the HOME directory during package
    load via pkg_resources when any of those files contain special
    characters (above ASCII 127).
    
    Testing:
    - added a file with an em dash to the HOME directory, then run
      impala-shell with Python 2.7 and without setuptools installed. This
      reproduced the issue before adding this patch, and is fixed by this
      patch.
    
    Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b
    Reviewed-on: http://gerrit.cloudera.org:8080/19641
    Reviewed-by: Joe McDonnell <jo...@cloudera.com>
    Tested-by: Michael Smith <mi...@cloudera.com>
---
 shell/pkg_resources.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/shell/pkg_resources.py b/shell/pkg_resources.py
index 70ecc44d5..977de194b 100644
--- a/shell/pkg_resources.py
+++ b/shell/pkg_resources.py
@@ -1,5 +1,3 @@
-from __future__ import print_function, unicode_literals
-
 """
   This file is redistributed under the Python Software Foundation License:
   http://docs.python.org/2/license.html