You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2026/08/31 12:44:54 UTC
[I] Commented code in MojoExtension.java [maven]
elharo opened a new issue, #12975:
URL: https://github.com/apache/maven/issues/12975
### Affected version
HEAD
### Bug description
figure out what to do about this, probably delete it
```
if (parameterConfiguration != null) {
Map<String, String> attributes = new HashMap<>(parameterConfiguration.getAttributes());
// if (isEmpty(parameterConfiguration.getAttribute("implementation"))
// && !isEmpty(parameter.getImplementation())) {
// attributes.put("implementation", parameter.getImplementation());
// }
parameterConfiguration = XmlNode.newInstance(
parameter.getName(),
parameterConfiguration.getValue(),
attributes,
parameterConfiguration.getChildren(),
parameterConfiguration.getInputLocation());
children.add(parameterConfiguration);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Commented code in MojoExtension.java [maven]
Posted by "Nikk8091 (via GitHub)" <gi...@apache.org>.
Nikk8091 commented on issue #12975:
URL: https://github.com/apache/maven/issues/12975#issuecomment-5596636570
Following up on my August 31 offer: is this cleanup still available? Before deleting the commented block, I would verify whether implementation-attribute propagation is intentionally handled elsewhere and keep the PR limited to MojoExtension and any necessary focused regression coverage. If there is a reason to retain or restore that logic, please let me know so the patch preserves the intended behavior. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Commented code in MojoExtension.java [maven]
Posted by "Nikk8091 (via GitHub)" <gi...@apache.org>.
Nikk8091 commented on issue #12975:
URL: https://github.com/apache/maven/issues/12975#issuecomment-5482146513
Hi, I would like to work on this issue.
I will trace how MojoExtension constructs parameter configuration and compare it with the corresponding logic in DefaultLifecycleExecutionPlanCalculator and BuildPlanExecutor. If the commented implementation-propagation block is obsolete, I will remove it and run the focused maven-testing tests.
I will keep the change narrowly scoped. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Commented code in MojoExtension.java [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet closed issue #12975: Commented code in MojoExtension.java
URL: https://github.com/apache/maven/issues/12975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Commented code in MojoExtension.java [maven]
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on issue #12975:
URL: https://github.com/apache/maven/issues/12975#issuecomment-6127293367
Proposed fix: https://github.com/apache/maven/pull/13443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org