You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2016/04/09 01:17:31 UTC

Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4324
    https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
-------

Allow the task to specify the persistent volume access to be read-only
or read-write. Note that the persistent volume is always created as
read-write.
If the task is the first consumer of the shared persistent volume, then
set the ownership of the persistent volume to match that of the task.
Otherwise, allow the task to be executed only if the ownership of the
persistent volume matches that of the task.
Added an option to run the test in mixed (default) mode or shared-only
mode. In mixed mode, multiple shards alternate between shared and
unshared persistent volumes for the tasks. In shared-only mode, all
shards use shared persistent volumes for the tasks.


Diffs
-----

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/validation.hpp d1f2323172cbf3bb052942a119b8531f9ccad48d 
  src/master/validation.cpp 504cd9b8bd5d40bb591b7aa5a23bd74cc210c2fc 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp cb181265482c884b02bdfc576f906aa0dd9f00f2 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 01c0ad6dbb6d509e62e769365586b3d23dcb240d 

Diff: https://reviews.apache.org/r/45963/diff/


Testing
-------

Tests successful.


Thanks,

Anindya Sinha


Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/
-----------------------------------------------------------

(Updated April 29, 2016, 12:16 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
-------

Updated based on changes in api to convert Resources to protobuf.


Bugs: MESOS-4324
    https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
-------

Allow the task to specify the persistent volume access to be read-only
or read-write. Note that the persistent volume is always created as
read-write.
If the task is the first consumer of the shared persistent volume, then
set the ownership of the persistent volume to match that of the task.
Otherwise, allow the task to be executed only if the ownership of the
persistent volume matches that of the task.
Added an option to run the test in mixed (default) mode or shared-only
mode. In mixed mode, multiple shards alternate between shared and
unshared persistent volumes for the tasks. In shared-only mode, all
shards use shared persistent volumes for the tasks.


Diffs (updated)
-----

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/validation.hpp 7fa1b892c1aff7453658c31e534dc272d1759b17 
  src/master/validation.cpp f458100d22ec1f9f10921c1c91b6931a5671e28f 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp cb181265482c884b02bdfc576f906aa0dd9f00f2 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp a6e748ae777b6280f5dab0a6fec7305f931f2c22 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 01c0ad6dbb6d509e62e769365586b3d23dcb240d 

Diff: https://reviews.apache.org/r/45963/diff/


Testing
-------

Tests successful.


Thanks,

Anindya Sinha


Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/
-----------------------------------------------------------

(Updated April 9, 2016, 2:27 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4324
    https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
-------

Allow the task to specify the persistent volume access to be read-only
or read-write. Note that the persistent volume is always created as
read-write.
If the task is the first consumer of the shared persistent volume, then
set the ownership of the persistent volume to match that of the task.
Otherwise, allow the task to be executed only if the ownership of the
persistent volume matches that of the task.
Added an option to run the test in mixed (default) mode or shared-only
mode. In mixed mode, multiple shards alternate between shared and
unshared persistent volumes for the tasks. In shared-only mode, all
shards use shared persistent volumes for the tasks.


Diffs (updated)
-----

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/validation.hpp d1f2323172cbf3bb052942a119b8531f9ccad48d 
  src/master/validation.cpp 504cd9b8bd5d40bb591b7aa5a23bd74cc210c2fc 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp cb181265482c884b02bdfc576f906aa0dd9f00f2 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 01c0ad6dbb6d509e62e769365586b3d23dcb240d 

Diff: https://reviews.apache.org/r/45963/diff/


Testing
-------

Tests successful.


Thanks,

Anindya Sinha