You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "bschuchardt (GitHub)" <gi...@apache.org> on 2019/12/30 21:24:39 UTC

[GitHub] [geode] bschuchardt opened pull request #4549: GEODE-7634: create an ArchUnitTest that asserts that geode-core only …

…uses the membership API

creating a new test to enforce use of membership APIs.  There are a few
exceptions in test code, plus others that aren't in the "integration
test" source set.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4549 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] echobravopapa commented on pull request #4549: GEODE-7634: create an ArchUnitTest that asserts that geode-core only …

Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
👍 

[ Full content available at: https://github.com/apache/geode/pull/4549 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #4549: GEODE-7634: create an ArchUnitTest that asserts that geode-core only …

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
I couldn't figure that one out.  Any attempts met with OOME when run from gradle.  That concern will go away when we start using Jigsaw and enforce API use.

[ Full content available at: https://github.com/apache/geode/pull/4549 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] echobravopapa commented on pull request #4549: GEODE-7634: create an ArchUnitTest that asserts that geode-core only …

Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
Nice to see test hooks reducing.

[ Full content available at: https://github.com/apache/geode/pull/4549 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org