You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Joel Koshy (JIRA)" <ji...@apache.org> on 2012/10/04 02:53:07 UTC
[jira] [Created] (KAFKA-542) Upgrade to metrics 3.x
Joel Koshy created KAFKA-542:
--------------------------------
Summary: Upgrade to metrics 3.x
Key: KAFKA-542
URL: https://issues.apache.org/jira/browse/KAFKA-542
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8
Reporter: Joel Koshy
Assignee: Joel Koshy
metrics 3.0.0 fixes some issues with the csv reporter that affect 0.8
E.g., with metrics 2.1.3 we would just have NumDelayedRequests.csv but with 3.0.0 we would have kafka.server.ProducerRequestPurgatory.NumDelayedRequests.csv and kafka.server.FetchRequestPurgatory.NumDelayedRequests.csv
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-542) Upgrade to metrics 3.x
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Koshy updated KAFKA-542:
-----------------------------
Status: Patch Available (was: Open)
I heard back from metrics-user that there is no immediate plan to release 3.0.0, so I think we should move forward with this change.
> Upgrade to metrics 3.x
> ----------------------
>
> Key: KAFKA-542
> URL: https://issues.apache.org/jira/browse/KAFKA-542
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Attachments: KAFKA-542-v1.patch
>
>
> metrics 3.0.0 fixes some issues with the csv reporter that affect 0.8
> E.g., with metrics 2.1.3 we would just have NumDelayedRequests.csv but with 3.0.0 we would have kafka.server.ProducerRequestPurgatory.NumDelayedRequests.csv and kafka.server.FetchRequestPurgatory.NumDelayedRequests.csv
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-542) Upgrade to metrics 3.x
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Koshy updated KAFKA-542:
-----------------------------
Attachment: KAFKA-542-v1.patch
Patch overview:
1 - I sent a mail to metrics-user group asking when 3.0.0 will be made
available in mvn central. For now, I just did a local build off this:
https://github.com/codahale/metrics.git -
10ccc80c0f574f104c4745a1ffa24af0ea92efbf
Added metrics-annotation-3.0.0-10ccc80c0.jar
metrics-core-3.0.0-10ccc80c0.jar to core/lib (which cannot be included in
the diff).
2 - Made couple of changes due to slight differences in 3.0.0 API.
3 - Fixed a small bug in the CSV reporter startup.
4 - Provided a sample config in server.properties.
> Upgrade to metrics 3.x
> ----------------------
>
> Key: KAFKA-542
> URL: https://issues.apache.org/jira/browse/KAFKA-542
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Attachments: KAFKA-542-v1.patch
>
>
> metrics 3.0.0 fixes some issues with the csv reporter that affect 0.8
> E.g., with metrics 2.1.3 we would just have NumDelayedRequests.csv but with 3.0.0 we would have kafka.server.ProducerRequestPurgatory.NumDelayedRequests.csv and kafka.server.FetchRequestPurgatory.NumDelayedRequests.csv
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-542) Upgrade to metrics 3.x
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Koshy updated KAFKA-542:
-----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the review. Committed to 0.8.
> Upgrade to metrics 3.x
> ----------------------
>
> Key: KAFKA-542
> URL: https://issues.apache.org/jira/browse/KAFKA-542
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Attachments: KAFKA-542-v1.patch
>
>
> metrics 3.0.0 fixes some issues with the csv reporter that affect 0.8
> E.g., with metrics 2.1.3 we would just have NumDelayedRequests.csv but with 3.0.0 we would have kafka.server.ProducerRequestPurgatory.NumDelayedRequests.csv and kafka.server.FetchRequestPurgatory.NumDelayedRequests.csv
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-542) Upgrade to metrics 3.x
Posted by "Neha Narkhede (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472577#comment-13472577 ]
Neha Narkhede commented on KAFKA-542:
-------------------------------------
+1. Thanks for the patch !
> Upgrade to metrics 3.x
> ----------------------
>
> Key: KAFKA-542
> URL: https://issues.apache.org/jira/browse/KAFKA-542
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Attachments: KAFKA-542-v1.patch
>
>
> metrics 3.0.0 fixes some issues with the csv reporter that affect 0.8
> E.g., with metrics 2.1.3 we would just have NumDelayedRequests.csv but with 3.0.0 we would have kafka.server.ProducerRequestPurgatory.NumDelayedRequests.csv and kafka.server.FetchRequestPurgatory.NumDelayedRequests.csv
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KAFKA-542) Upgrade to metrics 3.x
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Koshy closed KAFKA-542.
----------------------------
> Upgrade to metrics 3.x
> ----------------------
>
> Key: KAFKA-542
> URL: https://issues.apache.org/jira/browse/KAFKA-542
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Attachments: KAFKA-542-v1.patch
>
>
> metrics 3.0.0 fixes some issues with the csv reporter that affect 0.8
> E.g., with metrics 2.1.3 we would just have NumDelayedRequests.csv but with 3.0.0 we would have kafka.server.ProducerRequestPurgatory.NumDelayedRequests.csv and kafka.server.FetchRequestPurgatory.NumDelayedRequests.csv
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira