You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/01/19 20:37:26 UTC

[GitHub] [trafficserver] bneradt opened a new pull request #8620: is_stale_cache_response_returnable: verify HTTP method

bneradt opened a new pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620


   This adds the method verification check currently in
   is_cache_response_returnable to is_stale_cache_response_returnable. That
   is, if an object is being requested by the client and the object is in
   our cache, we can only reply with the cached object if the method of the
   incoming request is the same as the method of the request for the cached
   object.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt commented on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1045349901


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt commented on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1047246161


   [approve ci rockylinux]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt commented on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1047212398


   [approve ci fedora]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt removed a comment on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1045624608






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt removed a comment on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1047216223


   [approve ci fedora]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt removed a comment on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1045349901


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt commented on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1047216223


   [approve ci fedora]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt commented on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1045624608


   [approve ci fedora]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] mlibbey commented on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
mlibbey commented on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1022744515


   If the stale object method is GET, will we still be able to serve HEAD from cache?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt commented on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1045134322


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt removed a comment on pull request #8620: is_stale_cache_response_returnable: verify HTTP method

Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8620:
URL: https://github.com/apache/trafficserver/pull/8620#issuecomment-1045134322


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org