DO NOT REPLY [Bug 4104] New: - Null savedrequest at FormAuthenticator.authenticate()

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4104>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4104

Null savedrequest at FormAuthenticator.authenticate()

           Summary: Null savedrequest at FormAuthenticator.authenticate()
           Product: Tomcat 4
           Version: 4.0 Final
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Catalina
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: vicentesalvador@netscape.net


At the end of the method we have:

requestURI = savedRequestURL(session);
if (debug >= 1)
   log("Redirecting to original '" + requestURI + "'");
hres.sendRedirect(hres.encodeRedirectURL(requestURI));
return (false);

But the savedRequestURL can return null.
Steps to reproduce:
1. open the browser and type the UTL when the login form page resides:
   http://myserver:8080/login/login.jsp

2.Authenticate correctly and then the servers redirects you to:
  http://myserver:8080/null
I know that this is not usual but we need a method to detect this, and redirect
to a proper URL. Maybe this URL can be setted by a property param. If not
possible, a 4.0.1 timeframe patch could be:

requestURI = savedRequestURL(session);
if (debug >= 1)
   log("Redirecting to original '" + requestURI + "'");
if (requestURL == null)
    requestURL = "";
hres.sendRedirect(hres.encodeRedirectURL(requestURI));
return (false);

I've not tested this patch but it should work;