[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #6274: [Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics.

[GitBox <gi...@apache.org>]

mbrookhart commented on a change in pull request #6274:
URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r493874156



##########
File path: src/arith/analyzer.cc
##########
@@ -115,13 +115,18 @@ bool Analyzer::CanProve(const PrimExpr& expr) {
   return false;
 }
 
+// see other .cc file

Review comment:
       Which other cc file?

##########
File path: src/ir/module.cc
##########
@@ -247,8 +227,8 @@ void IRModuleNode::AddTypeDef(const GlobalTypeVar& var, const TypeData& type, bo
   AddTypeDefUnchecked(var, type, update);
   // need to kind check at the end because the check can look up
   // a definition potentially
-  CHECK(relay::KindCheck(type, GetRef<IRModule>(this)) == TypeKind::kTypeData)
-      << "Invalid or malformed typedata given to module: " << type;
+  // CHECK(relay::KindCheck(type, GetRef<IRModule>(this)) == TypeKind::kTypeData)
+  //     << "Invalid or malformed typedata given to module: " << type;

Review comment:
       uncomment or remove.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org