[GitHub] [druid] LakshSingla commented on a diff in pull request #13475: Remove stray reference to fix OOM while merging sketches

[GitBox <gi...@apache.org>]

LakshSingla commented on code in PR #13475:
URL: https://github.com/apache/druid/pull/13475#discussion_r1037778390


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerSketchFetcher.java:
##########
@@ -155,7 +152,17 @@ CompletableFuture<Either<Long, ClusterByPartitions>> inMemoryFullSketchMerging(
             mergedStatisticsCollector.clear();
           }
         }
-      });
+      }));
+    });
+
+    partitionFuture.whenComplete((result, exception) -> {

Review Comment:
   Is this a failsafe condition or would this be required? From my understanding, the successful completion of partitionFuture depends on the completion of the underlying futures, and in case of unsuccessful completion, we shouldn't have any issue with prematurely cancelling any underlying future. I might have missed something though. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org