You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/04/10 09:54:22 UTC

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #525: [YUNIKORN-1668] Check there must be one more limit setting for group with specific name defined in the config when use wildcard group limit

codecov[bot] commented on PR #525:
URL: https://github.com/apache/yunikorn-core/pull/525#issuecomment-1501623117

   ## [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#525](https://codecov.io/gh/apache/yunikorn-core/pull/525?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb31bc2) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/5fa8c6a37aa290b825cd358d121a938107a24bd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fa8c6a) will **increase** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #525      +/-   ##
   ==========================================
   + Coverage   75.00%   75.07%   +0.07%     
   ==========================================
     Files          70       70              
     Lines       11309    11329      +20     
   ==========================================
   + Hits         8482     8505      +23     
   + Misses       2529     2527       -2     
   + Partials      298      297       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/configs/configvalidator.go](https://codecov.io/gh/apache/yunikorn-core/pull/525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `89.04% <100.00%> (+0.53%)` | :arrow_up: |
   
   ... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/yunikorn-core/pull/525/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org