You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficcontrol.apache.org by oc...@apache.org on 2020/11/13 17:38:57 UTC

[trafficcontrol] 04/06: Fix test failures (#5273)

This is an automated email from the ASF dual-hosted git repository.

ocket8888 pushed a commit to branch 5.0.x
in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git

commit 3e649f0bb708d1d94d932a010b284eadd463d743
Author: Steve Hamrick <sh...@users.noreply.github.com>
AuthorDate: Wed Nov 11 15:52:40 2020 -0700

    Fix test failures (#5273)
    
    (cherry picked from commit a9401b76aa19495b516760b62168f8e66b98ce08)
---
 .../test/end_to_end/servers/servers-spec.js           | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/traffic_portal/test/end_to_end/servers/servers-spec.js b/traffic_portal/test/end_to_end/servers/servers-spec.js
index 61319a0..f9dda58 100644
--- a/traffic_portal/test/end_to_end/servers/servers-spec.js
+++ b/traffic_portal/test/end_to_end/servers/servers-spec.js
@@ -54,7 +54,10 @@ describe('Traffic Portal Servers Test Suite', function() {
 		pageData.hostName.sendKeys(mockVals.hostName);
 		pageData.domainName.sendKeys(mockVals.domainName);
 		commonFunctions.selectDropdownbyNum(pageData.cdn, 2); // the ALL CDN is first so let's pick a real CDN
-		commonFunctions.selectDropdownbyNum(pageData.cachegroup, 1);
+		// Assign this server to a created cache-group, needed for Topologies tests
+		pageData.cachegroup.all(by.tagName("option")).then(function(options) {
+		    options[options.length-1].click();
+		});
 		element(by.css("#type [label='EDGE']")).click();
 		commonFunctions.selectDropdownbyNum(pageData.profile, 1);
 		commonFunctions.selectDropdownbyNum(pageData.physLocation, 1);
@@ -123,9 +126,10 @@ describe('Traffic Portal Servers Test Suite', function() {
 		expect(pageData.submitButton.isEnabled()).toBe(false);
 		commonFunctions.selectDropdownbyNum(pageData.selectFormDropdown, 1);
 		expect(pageData.submitButton.isEnabled()).toBe(true);
-		pageData.submitButton.click();
-		element.all(by.css('tbody tr')).then(function(totalRows) {
-			expect(totalRows.length).toBe(1);
+		pageData.submitButton.click().then(function() {
+			element.all(by.css('tbody tr')).then(function(totalRows) {
+				expect(totalRows.length).toBe(1);
+			});
 		});
 	});
 
@@ -136,11 +140,4 @@ describe('Traffic Portal Servers Test Suite', function() {
 		pageData.viewDeliveryServicesMenuItem.click();
 		expect(browser.getCurrentUrl().then(commonFunctions.urlPath)).toMatch(commonFunctions.urlPath(browser.baseUrl)+"#!/servers/[0-9]+/delivery-services");
 	});
-
-	it('should ensure you cannot clone delivery service assignments because there are no delivery services assigned to the server', function() {
-		console.log('Ensure you cannot clone delivery service assignments for ' + mockVals.hostName);
-		pageData.moreBtn.click();
-		expect(element(by.css('.clone-ds-assignments')).isPresent()).toEqual(false);
-	});
-
 });