You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by abhinandanprateek <gi...@git.apache.org> on 2016/08/30 10:49:14 UTC
[GitHub] cloudstack pull request #1667: CLOUDSTACK-9481: Convert MyISAM table to Inno...
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1667
CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack innodb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1667.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1667
----
commit 842fb7004c8a7dc2fa8e5a03d8555cdc70febb90
Author: Abhinandan Prateek <ab...@shapeblue.com>
Date: 2016-08-30T10:46:40Z
CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1667: CLOUDSTACK-9481: Convert MyISAM table to InnoDB for ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1667
@abhinandanprateek can you reopen this for 4.9 branch, since it's a bugfix. LTS users should all be on innodb to avoid any replication issues, please also move the changes suitably to 4.9.0->4.9.1(.0) upgrade path sql. Otherwise LGTM.
Tried on a local setup. To list tables that are on non-InnoDb engines:
`SELECT table_schema,table_name,engine FROM information_schema.tables WHERE engine != 'InnoDB' AND table_schema NOT IN ('mysql','performance_schema','information_schema');`
Except for following tables, all should be on InnoDb engine.
table_schema | table_name | engine
--- | --- | ---
cloud | op_lock | MEMORY
cloud | op_nwgrp_work | MEMORY
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1667: CLOUDSTACK-9481: Convert MyISAM table to InnoDB for ...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1667
Closing as it is already merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1667: CLOUDSTACK-9481: Convert MyISAM table to InnoDB for ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1667
@abhinandanprateek thanks, can you close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1667: CLOUDSTACK-9481: Convert MyISAM table to InnoDB for ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1667
LGTM. @abhinandanprateek can you edit the base branch of this PR to 4.9. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1667: CLOUDSTACK-9481: Convert MyISAM table to Inno...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek closed the pull request at:
https://github.com/apache/cloudstack/pull/1667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1667: CLOUDSTACK-9481: Convert MyISAM table to InnoDB for ...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1667
@rhtyd created another PR for 4.9 https://github.com/apache/cloudstack/pull/1670
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---