[GitHub] [beam] kileys commented on a change in pull request #16231: [BEAM-13271] Bump errorprone to 2.10.0

[GitBox <gi...@apache.org>]

kileys commented on a change in pull request #16231:
URL: https://github.com/apache/beam/pull/16231#discussion_r768943167



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Regex.java
##########
@@ -978,10 +978,14 @@ public void processElement(@Element String element, OutputReceiver<String> r)
   public static class Split extends PTransform<PCollection<String>, PCollection<String>> {
     final Pattern pattern;
     boolean outputEmpty;
+    int splitLimit;
 
     public Split(Pattern pattern, boolean outputEmpty) {
       this.pattern = pattern;
       this.outputEmpty = outputEmpty;
+      // Use split with limit=0 iff this.outputEmpty is true, since it implicitly drops trailing

Review comment:
       ```suggestion
         // Use split with limit=0 iff this.outputEmpty is false, since it implicitly drops trailing
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org