You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "azexcy (via GitHub)" <gi...@apache.org> on 2023/10/08 07:52:06 UTC
[PR] Improve exception handle at AbstractPipelineJob and refactor processFailed [shardingsphere]
azexcy opened a new pull request, #28677:
URL: https://github.com/apache/shardingsphere/pull/28677
It is not enough to catch exceptions in the `doPrepare` method, other methods may also throw runtime exceptions
Changes proposed in this pull request:
- Improve exception handle at AbstractPipelineJob
- Refactor processFailed
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve exception handle at AbstractPipelineJob and refactor processFailed [shardingsphere]
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on code in PR #28677:
URL: https://github.com/apache/shardingsphere/pull/28677#discussion_r1349650326
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/job/AbstractPipelineJob.java:
##########
@@ -90,24 +90,17 @@ protected void prepare(final PipelineJobItemContext jobItemContext) {
try {
doPrepare(jobItemContext);
// CHECKSTYLE:OFF
- } catch (final RuntimeException ex) {
- // CHECKSTYLE:ON
- processFailed(jobItemContext, ex);
- throw ex;
- // CHECKSTYLE:OFF
} catch (final SQLException ex) {
// CHECKSTYLE:ON
- processFailed(jobItemContext, ex);
throw new PipelineInternalException(ex);
}
}
protected abstract void doPrepare(PipelineJobItemContext jobItemContext) throws SQLException;
- protected void processFailed(final PipelineJobItemContext jobItemContext, final Exception ex) {
- String jobId = jobItemContext.getJobId();
- log.error("job prepare failed, {}-{}", jobId, jobItemContext.getShardingItem(), ex);
- jobAPI.updateJobItemErrorMessage(jobItemContext.getJobId(), jobItemContext.getShardingItem(), ex);
+ protected void processFailed(final String jobId, final int shardingItem, final Exception ex) {
+ log.error("job prepare failed, {}-{}", jobId, shardingItem, ex);
+ jobAPI.updateJobItemErrorMessage(jobId, shardingItem, ex);
jobAPI.stop(jobId);
}
Review Comment:
Could we move `processFailed` to `AbstractSimplePipelineJob`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve exception handle at AbstractPipelineJob and refactor processFailed [shardingsphere]
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #28677:
URL: https://github.com/apache/shardingsphere/pull/28677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org