You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2019/02/26 23:48:42 UTC
[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12610
Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
......................................................................
IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
One of the stress related flag is not available in the development build.
Testing done: Ran the test with release build and verified that it's skipped.
Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
---
M tests/custom_cluster/test_exchange_deferred_batches.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/12610/1
--
To view, visit http://gerrit.cloudera.org:8080/12610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
Gerrit-Change-Number: 12610
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12610 )
Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
......................................................................
IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
The startup flag stress_datastream_recvr_delay_ms is not available in
development builds. Skip the test in non-developement builds.
Testing done: Ran the test with release build and verified that it's skipped.
Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
Reviewed-on: http://gerrit.cloudera.org:8080/12610
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_exchange_deferred_batches.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
Gerrit-Change-Number: 12610
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Hello Thomas Marshall, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12610
to look at the new patch set (#2).
Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
......................................................................
IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
The startup flag stress_datastream_recvr_delay_ms is not available in
development builds. Skip the test in non-developement builds.
Testing done: Ran the test with release build and verified that it's skipped.
Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
---
M tests/custom_cluster/test_exchange_deferred_batches.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/12610/2
--
To view, visit http://gerrit.cloudera.org:8080/12610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
Gerrit-Change-Number: 12610
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12610 )
Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2263/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
Gerrit-Change-Number: 12610
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 00:13:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12610 )
Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
Gerrit-Change-Number: 12610
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:53:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12610 )
Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3837/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
Gerrit-Change-Number: 12610
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:54:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12610 )
Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
Gerrit-Change-Number: 12610
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:54:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12610 )
Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5caaa6fa39d6c97f313b675838c27740af9aa1d5
Gerrit-Change-Number: 12610
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 04:01:25 +0000
Gerrit-HasComments: No