You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "James Peach (Created) (JIRA)" <ji...@apache.org> on 2012/01/19 06:04:39 UTC
[jira] [Created] (TS-1083) initial SSL next protocol negotiation
support
initial SSL next protocol negotiation support
---------------------------------------------
Key: TS-1083
URL: https://issues.apache.org/jira/browse/TS-1083
Project: Traffic Server
Issue Type: Improvement
Components: SSL
Reporter: James Peach
Assignee: James Peach
Priority: Minor
Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1083) initial SSL next protocol negotiation
support
Posted by "Leif Hedstrom (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192288#comment-13192288 ]
Leif Hedstrom commented on TS-1083:
-----------------------------------
Well, that's one #define available in OpenSSL when NPN is available. I have no problems with your patch, so just decide which route you think we should go. I picked OPENSSL_NPN_NEGOTIATED, because I saw other solutions doing the same :).
> initial SSL next protocol negotiation support
> ---------------------------------------------
>
> Key: TS-1083
> URL: https://issues.apache.org/jira/browse/TS-1083
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch
>
>
> Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1083) initial SSL next protocol negotiation
support
Posted by "James Peach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193110#comment-13193110 ]
James Peach commented on TS-1083:
---------------------------------
Let's just leave the patch as it. It's overkill but harmless overkill.
> initial SSL next protocol negotiation support
> ---------------------------------------------
>
> Key: TS-1083
> URL: https://issues.apache.org/jira/browse/TS-1083
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch
>
>
> Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1083) initial SSL next protocol negotiation
support
Posted by "James Peach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192268#comment-13192268 ]
James Peach commented on TS-1083:
---------------------------------
Ah, I just didn't notice that there was a OPENSSL_NPN_NEGOTIATED. If I had I would not have bothered with the autoconf checks.
> initial SSL next protocol negotiation support
> ---------------------------------------------
>
> Key: TS-1083
> URL: https://issues.apache.org/jira/browse/TS-1083
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch
>
>
> Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1083) initial SSL next protocol negotiation
support
Posted by "Leif Hedstrom (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-1083:
---------------------------------
Assignee: James Peach (was: Leif Hedstrom)
> initial SSL next protocol negotiation support
> ---------------------------------------------
>
> Key: TS-1083
> URL: https://issues.apache.org/jira/browse/TS-1083
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
> Reporter: James Peach
> Assignee: James Peach
> Priority: Minor
> Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch
>
>
> Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1083) initial SSL next protocol negotiation
support
Posted by "James Peach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-1083:
----------------------------
Fix Version/s: 3.1.2
> initial SSL next protocol negotiation support
> ---------------------------------------------
>
> Key: TS-1083
> URL: https://issues.apache.org/jira/browse/TS-1083
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
> Reporter: James Peach
> Assignee: James Peach
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch
>
>
> Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1083) initial SSL next protocol negotiation
support
Posted by "Leif Hedstrom (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192190#comment-13192190 ]
Leif Hedstrom commented on TS-1083:
-----------------------------------
Quick question:
when I first looked at this, my code simply did
#ifdef OPENSSL_NPN_NEGOTIATED
Is there a reason we have to have autoconf "check" for NPN support? Is there ever a reason not to support NPN (even with just HTTPS) if the OpenSSL library has it available?
> initial SSL next protocol negotiation support
> ---------------------------------------------
>
> Key: TS-1083
> URL: https://issues.apache.org/jira/browse/TS-1083
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch
>
>
> Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1083) initial SSL next protocol negotiation
support
Posted by "Leif Hedstrom (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192289#comment-13192289 ]
Leif Hedstrom commented on TS-1083:
-----------------------------------
And comment on the bug here what you think we should do. Trying to wrap up 3.1.2 this week, but we should get as much as possible in.
> initial SSL next protocol negotiation support
> ---------------------------------------------
>
> Key: TS-1083
> URL: https://issues.apache.org/jira/browse/TS-1083
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch
>
>
> Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1083) initial SSL next protocol negotiation
support
Posted by "James Peach (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach reassigned TS-1083:
-------------------------------
Assignee: Leif Hedstrom (was: James Peach)
Leif, can you review and apply if appropriate. Thanks.
> initial SSL next protocol negotiation support
> ---------------------------------------------
>
> Key: TS-1083
> URL: https://issues.apache.org/jira/browse/TS-1083
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch
>
>
> Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1083) initial SSL next protocol negotiation
support
Posted by "James Peach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-1083:
----------------------------
Attachment: 0002-Initial-NPN-plumbing.patch
0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch
Attached 1 patches. First just adds the autoconf checks. Second adds make the calls and advertises the HTTP protocol.
Careful, if you build on OS X with MacPorts /opt/local/bin will be linked before /usr/local/ssl and NPN support won't be detected. This is difficult to avoid.
> initial SSL next protocol negotiation support
> ---------------------------------------------
>
> Key: TS-1083
> URL: https://issues.apache.org/jira/browse/TS-1083
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
> Reporter: James Peach
> Assignee: James Peach
> Priority: Minor
> Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch
>
>
> Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira