[GitHub] [arrow] AlvinJ15 commented on a change in pull request #11759: ARROW-14795: [C++] Fix issue on replace with mask for null values

[GitBox <gi...@apache.org>]

AlvinJ15 commented on a change in pull request #11759:
URL: https://github.com/apache/arrow/pull/11759#discussion_r756341629



##########
File path: cpp/src/arrow/compute/kernels/vector_replace.cc
##########
@@ -154,9 +172,10 @@ Status ReplaceWithArrayMask(KernelContext* ctx, const ArrayData& array,
   uint8_t* out_values = output->buffers[1]->mutable_data();
   const uint8_t* mask_bitmap = mask.MayHaveNulls() ? mask.buffers[0]->data() : nullptr;
   const uint8_t* mask_values = mask.buffers[1]->data();
-  const bool replacements_bitmap = replacements.is_array()
-                                       ? replacements.array()->MayHaveNulls()
-                                       : !replacements.scalar()->is_valid;
+  const bool replacements_bitmap =

Review comment:
       solved




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org