You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/22 07:00:10 UTC

[GitHub] [flink] dawidwys opened a new pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

dawidwys opened a new pull request #13450:
URL: https://github.com/apache/flink/pull/13450


   ## What is the purpose of the change
   
   Avro 1.9.x introduced yet another mechanism for registering/looking up
   conversions for logical types.
   
   If a logical type is part of a union a static field MODEL$ of type SpecificData
   is added to the generated Avro class with registered conversions for logical types.
   In this commit we try to use that SpecificData in AvroSerializer and
   Avro(De)SerializationSchema whenever available instead of instantiating a new
   unrelated one.
   
   The change is backwards compatible and if the field is not available we
   fallback to the old ways.
   
   ## Verifying this change
   
   This change added tests in respective test classes for AvroSerializer and Avro(De)SerializationSchema.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (**yes** / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696655915


   It is relevant for `AvroSerializer` (which I updated through `AvroFactory#fromSpecific` and added a test for it: `AvroUnionLogicalSerializerTest.java`).
   
   I checked all places where we instantiate the `SpecificData`manually. In the `AvroInputFormat` we use the `SpecificDatumReader` which should just work (it has that logic of acquiring `SpecificData` built in).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-699977074


   Seems like this fixed causes a 10% performance regression https://issues.apache.org/jira/browse/FLINK-19439 . @dawidwys would you like to pick that ticket up?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696552930


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d4084790b05f22ceaf246d018eab3f31ba95805a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6755",
       "triggerID" : "d4084790b05f22ceaf246d018eab3f31ba95805a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d4084790b05f22ceaf246d018eab3f31ba95805a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6755) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696546030


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d4084790b05f22ceaf246d018eab3f31ba95805a (Fri Feb 19 07:28:40 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys merged pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #13450:
URL: https://github.com/apache/flink/pull/13450


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-697264026


   Thanks for clarifying!
   
   Looks good to me, +1 to merge this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys merged pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #13450:
URL: https://github.com/apache/flink/pull/13450


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696649675


   Looks good to me.
   
   Is this also relevant for other Avro parts, like AvroInputFormat, AvroSerializer, ... ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696655915


   It is relevant for `AvroSerializer` (which I updated through `AvroFactory#fromSpecific` and added a test for it: `AvroUnionLogicalSerializerTest.java`).
   
   I checked all places where we instantiate the `SpecificData`manually. In the `AvroInputFormat` we use the `SpecificDatumReader` which should just work (it has that logic of acquiring `SpecificData` built in).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696552930


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d4084790b05f22ceaf246d018eab3f31ba95805a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6755",
       "triggerID" : "d4084790b05f22ceaf246d018eab3f31ba95805a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d4084790b05f22ceaf246d018eab3f31ba95805a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6755) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696552930


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d4084790b05f22ceaf246d018eab3f31ba95805a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d4084790b05f22ceaf246d018eab3f31ba95805a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d4084790b05f22ceaf246d018eab3f31ba95805a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys edited a comment on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
dawidwys edited a comment on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696655915


   It is relevant for `AvroSerializer` (which I updated through `AvroFactory#fromSpecific` and added a test for it: `AvroUnionLogicalSerializerTest.java`).
   
   I checked all places where we instantiate the `SpecificData`manually and updated those.
   
   In the `AvroInputFormat` we use the `SpecificDatumReader` which should just work (it has that logic of acquiring `SpecificData` built in).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696546030






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-698130777


   Thanks @StephanEwen for the review, merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys edited a comment on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
dawidwys edited a comment on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696655915


   It is relevant for `AvroSerializer` (which I updated through `AvroFactory#fromSpecific` and added a test for it: `AvroUnionLogicalSerializerTest.java`).
   
   I checked all places where we instantiate the `SpecificData`manually and updated those.
   
   In the `AvroInputFormat` we use the `SpecificDatumReader` which should just work (it has that logic of acquiring `SpecificData` built in).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696552930






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-698130777


   Thanks @StephanEwen for the review, merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696546030


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d4084790b05f22ceaf246d018eab3f31ba95805a (Tue Sep 22 07:03:11 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #13450:
URL: https://github.com/apache/flink/pull/13450#issuecomment-696649675


   Looks good to me.
   
   Is this also relevant for other Avro parts, like AvroInputFormat, AvroSerializer, ... ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org