You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/24 01:14:56 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #2597: Revert "board/sim: Remove the too strict warning"
yamt opened a new pull request #2597:
URL: https://github.com/apache/incubator-nuttx/pull/2597
## Summary
Revert "board/sim: Remove the too strict warning"
This reverts commit e70bff723b5e2eecb741f43bb2ecc5a220d3bf8c.
* These warnings sometimes find real bugs. There are ways to disable
the specific warnings for the specific code (eg. libcxx) selectively.
* It doesn't make much sense to disable these warnings only on sim.
There are many boards with -Wall -Wshadow. Because the sim is
mainly for development and testing, it should be less forgiving
than real boards.
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2597: Revert "board/sim: Remove the too strict warning"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2597:
URL: https://github.com/apache/incubator-nuttx/pull/2597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2597: Revert "board/sim: Remove the too strict warning"
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2597:
URL: https://github.com/apache/incubator-nuttx/pull/2597#discussion_r548776307
##########
File path: libs/libxx/libcxx.defs
##########
@@ -58,6 +58,18 @@ CXXFLAGS += ${shell $(DEFINE) "$(CC)" _LIBCPP_BUILDING_LIBRARY}
libcxx/src/barrier.cpp_CXXFLAGS += -Wno-shadow
libcxx/src/locale.cpp_CXXFLAGS += -Wno-shadow
+# Workaround the following warning with "c++ (Ubuntu 9.3.0-10ubuntu2) 9.3.0"
+# For files including filesyste_common.h.
+#
+# libcxx/src/filesystem/filesystem_common.h:200:27: error: declaration 'struct timespec' does not declare anything [-Werror]
+# 200 | using TimeSpec = struct ::timespec;
+# | ^~~~~~~~
+# libcxx/src/filesystem/filesystem_common.h:201:24: error: declaration 'struct stat' does not declare anything [-Werror]
+# 201 | using StatT = struct ::stat;
+# | ^~~~
+libcxx/src/filesystem/directory_iterator.cpp_CXXFLAGS += -Wno-shadow -Wno-error
Review comment:
i removed unnecessary -Wno-error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2597: Revert "board/sim: Remove the too strict warning"
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2597:
URL: https://github.com/apache/incubator-nuttx/pull/2597#discussion_r548765396
##########
File path: libs/libxx/libcxx.defs
##########
@@ -58,6 +58,18 @@ CXXFLAGS += ${shell $(DEFINE) "$(CC)" _LIBCPP_BUILDING_LIBRARY}
libcxx/src/barrier.cpp_CXXFLAGS += -Wno-shadow
libcxx/src/locale.cpp_CXXFLAGS += -Wno-shadow
+# Workaround the following warning with "c++ (Ubuntu 9.3.0-10ubuntu2) 9.3.0"
+# For files including filesyste_common.h.
+#
+# libcxx/src/filesystem/filesystem_common.h:200:27: error: declaration 'struct timespec' does not declare anything [-Werror]
+# 200 | using TimeSpec = struct ::timespec;
+# | ^~~~~~~~
+# libcxx/src/filesystem/filesystem_common.h:201:24: error: declaration 'struct stat' does not declare anything [-Werror]
+# 201 | using StatT = struct ::stat;
+# | ^~~~
+libcxx/src/filesystem/directory_iterator.cpp_CXXFLAGS += -Wno-shadow -Wno-error
Review comment:
maybe. i will check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2597: Revert "board/sim: Remove the too strict warning"
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2597:
URL: https://github.com/apache/incubator-nuttx/pull/2597#discussion_r548770862
##########
File path: libs/libxx/libcxx.defs
##########
@@ -58,6 +58,18 @@ CXXFLAGS += ${shell $(DEFINE) "$(CC)" _LIBCPP_BUILDING_LIBRARY}
libcxx/src/barrier.cpp_CXXFLAGS += -Wno-shadow
libcxx/src/locale.cpp_CXXFLAGS += -Wno-shadow
+# Workaround the following warning with "c++ (Ubuntu 9.3.0-10ubuntu2) 9.3.0"
+# For files including filesyste_common.h.
+#
+# libcxx/src/filesystem/filesystem_common.h:200:27: error: declaration 'struct timespec' does not declare anything [-Werror]
+# 200 | using TimeSpec = struct ::timespec;
+# | ^~~~~~~~
+# libcxx/src/filesystem/filesystem_common.h:201:24: error: declaration 'struct stat' does not declare anything [-Werror]
+# 201 | using StatT = struct ::stat;
+# | ^~~~
+libcxx/src/filesystem/directory_iterator.cpp_CXXFLAGS += -Wno-shadow -Wno-error
Review comment:
it isn't necessary after 0001-libc-NFC-Fix-several-GCC-warnings-in-the-test-suite.patch. i will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2597: Revert "board/sim: Remove the too strict warning"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2597:
URL: https://github.com/apache/incubator-nuttx/pull/2597#discussion_r548500247
##########
File path: libs/libxx/libcxx.defs
##########
@@ -58,6 +58,18 @@ CXXFLAGS += ${shell $(DEFINE) "$(CC)" _LIBCPP_BUILDING_LIBRARY}
libcxx/src/barrier.cpp_CXXFLAGS += -Wno-shadow
libcxx/src/locale.cpp_CXXFLAGS += -Wno-shadow
+# Workaround the following warning with "c++ (Ubuntu 9.3.0-10ubuntu2) 9.3.0"
+# For files including filesyste_common.h.
+#
+# libcxx/src/filesystem/filesystem_common.h:200:27: error: declaration 'struct timespec' does not declare anything [-Werror]
+# 200 | using TimeSpec = struct ::timespec;
+# | ^~~~~~~~
+# libcxx/src/filesystem/filesystem_common.h:201:24: error: declaration 'struct stat' does not declare anything [-Werror]
+# 201 | using StatT = struct ::stat;
+# | ^~~~
+libcxx/src/filesystem/directory_iterator.cpp_CXXFLAGS += -Wno-shadow -Wno-error
Review comment:
already fixed in mainline?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org