You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Balázs Donát Bessenyei <be...@cloudera.com> on 2016/07/20 13:59:18 UTC
Re: Review Request 34200: Review request for FLUME-2689,
reloading conf file leads syslogTcpSource not receives any event
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34200/#review142936
-----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java (line 23)
<https://reviews.apache.org/r/34200/#comment208606>
Can you please expand this import?
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java (line 30)
<https://reviews.apache.org/r/34200/#comment208607>
Can you please expand this import?
- Bal�zs Don�t Bessenyei
On May 14, 2015, 8:19 a.m., wei yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34200/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 8:19 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2689
> https://issues.apache.org/jira/browse/FLUME-2689
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Reloading conf file will stop old syslog source and start new syslog source. Stopping syslog tcp source only closes the NioServerSocketChannel, resulting in the client sends data through the old channel. In that case, the new source never receives data. The tcpdump shows the events have received but the new source doesn't and ss shows the client connection stays same with old one.
> The right way to stop syslog source is close both the NioSocketChannel and NioServerSocketChannel, and shutdown the executor.
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java e84e4b6
>
> Diff: https://reviews.apache.org/r/34200/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> wei yang
>
>
Re: Review Request 34200: Review request for FLUME-2689,
reloading conf file leads syslogTcpSource not receives any event
Posted by wei yang <wy...@gmail.com>.
> On \u4e03\u6708 20, 2016, 1:59 p.m., Bal�zs Don�t Bessenyei wrote:
> > flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java, line 39
> > <https://reviews.apache.org/r/34200/diff/1/?file=958822#file958822line39>
> >
> > Can you please expand this import?
Thanks for the review. I have updated patch.
- wei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34200/#review142936
-----------------------------------------------------------
On \u4e03\u6708 26, 2016, 8:30 a.m., wei yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34200/
> -----------------------------------------------------------
>
> (Updated \u4e03\u6708 26, 2016, 8:30 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2689
> https://issues.apache.org/jira/browse/FLUME-2689
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Reloading conf file will stop old syslog source and start new syslog source. Stopping syslog tcp source only closes the NioServerSocketChannel, resulting in the client sends data through the old channel. In that case, the new source never receives data. The tcpdump shows the events have received but the new source doesn't and ss shows the client connection stays same with old one.
> The right way to stop syslog source is close both the NioSocketChannel and NioServerSocketChannel, and shutdown the executor.
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java e84e4b6
> flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java 22fa200
>
> Diff: https://reviews.apache.org/r/34200/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> wei yang
>
>