You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/25 10:20:50 UTC
[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions
chenzhx commented on code in PR #36663:
URL: https://github.com/apache/spark/pull/36663#discussion_r881484738
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java:
##########
@@ -196,6 +196,84 @@
* <li>Since version: 3.4.0</li>
* </ul>
* </li>
+ * <li>Name: <code>DATE_ADD</code>
+ * <ul>
+ * <li>SQL semantic: <code>DATE_ADD(start_date, num_days)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>DATEDIFF</code>
+ * <ul>
+ * <li>SQL semantic: <code>DATEDIFF(end_date, start_date)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>TRUNC</code>
+ * <ul>
+ * <li>SQL semantic: <code>TRUNC(date, format)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>EXTRACT</code>
+ * <ul>
+ * <li>SQL semantic: <code>EXTRACT(field, source, replacement)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>SECOND</code>
+ * <ul>
+ * <li>SQL semantic: <code>SECOND(timestamp, timezone)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>MINUTE</code>
+ * <ul>
+ * <li>SQL semantic: <code>MINUTE(timestamp, timezone)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>HOUR</code>
+ * <ul>
+ * <li>SQL semantic: <code>HOUR(timestamp, timezone)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>MONTH</code>
+ * <ul>
+ * <li>SQL semantic: <code>MONTH(date)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>QUARTER</code>
+ * <ul>
+ * <li>SQL semantic: <code>QUARTER(date)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>YEAR</code>
+ * <ul>
+ * <li>SQL semantic: <code>YEAR(date)</code></li>
+ * <li>Since version: 3.4.0</li>
+ * </ul>
+ * </li>
+ * <li>Name: <code>DAYOFWEEK</code>
Review Comment:
But the name is DAYOFWEEK in spark.
https://github.com/apache/spark/blob/2f8613f22c0750c00cf1dcfb2f31c431d8dc1be7/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org