You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vladimir Beliaev (JIRA)" <ji...@apache.org> on 2007/04/18 15:04:15 UTC
[jira] Created: (HARMONY-3697) [drlvm][kernel] remove kernel
classes build warnings in reflect implementation
[drlvm][kernel] remove kernel classes build warnings in reflect implementation
------------------------------------------------------------------------------
Key: HARMONY-3697
URL: https://issues.apache.org/jira/browse/HARMONY-3697
Project: Harmony
Issue Type: Sub-task
Components: DRLVM
Environment: any
Reporter: Vladimir Beliaev
Remained pack of warnings is caused by java.lang.reflect implementation classes which are:
org\apache\harmony\fortress\security\PolicyUtils.java
org\apache\harmony\lang\reflect\Reflection.java
org\apache\harmony\lang\reflect\parser\SignatureParser.java
org\apache\harmony\lang\reflect\parser\SignatureParserTokenTypes.java
org\apache\harmony\lang\reflect\repository\ParameterizedTypeRepository.java
org\apache\harmony\lang\reflect\repository\TypeVariableRepository.java
org\apache\harmony\lang\reflect\repository\WildcardTypeRepository.java
org\apache\harmony\lang\reflect\support\AuxiliaryCreator.java
org\apache\harmony\lang\reflect\support\AuxiliaryFinder.java
org\apache\harmony\lang\reflect\support\AuxiliaryLoader.java
The warning cause is not yet evaluated.
Thanks
Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3697) [drlvm][kernel] remove kernel
classes build warnings in reflect implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-3697:
---------------------------------------
Assignee: Gregory Shimansky
What is the reason to keep these 2 warnings?
> [drlvm][kernel] remove kernel classes build warnings in reflect implementation
> ------------------------------------------------------------------------------
>
> Key: HARMONY-3697
> URL: https://issues.apache.org/jira/browse/HARMONY-3697
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assigned To: Gregory Shimansky
> Attachments: H3697.patch
>
>
> Remained pack of warnings is caused by java.lang.reflect implementation classes which are:
> org\apache\harmony\lang\reflect\Reflection.java
> org\apache\harmony\lang\reflect\parser\SignatureParser.java
> org\apache\harmony\lang\reflect\parser\SignatureParserTokenTypes.java
> org\apache\harmony\lang\reflect\repository\ParameterizedTypeRepository.java
> org\apache\harmony\lang\reflect\repository\TypeVariableRepository.java
> org\apache\harmony\lang\reflect\repository\WildcardTypeRepository.java
> org\apache\harmony\lang\reflect\support\AuxiliaryCreator.java
> org\apache\harmony\lang\reflect\support\AuxiliaryFinder.java
> org\apache\harmony\lang\reflect\support\AuxiliaryLoader.java
> The warning cause is not yet evaluated.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3697) [drlvm][kernel] remove kernel
classes build warnings in reflect implementation
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Beliaev updated HARMONY-3697:
--------------------------------------
Attachment: H3697.patch
So, the patch for final pack of warnings (excepting PolicyUtils noted by mistake) is attached.
Here more warnings relate to improper imports or dead code.
Still I kept two warnings (nothing is perfect) in SignatureParser.java like:
[javac] 1. WARNING in org\apache\harmony\lang\reflect\parser\SignatureParser.java
[javac] (at line 2023)
[javac] Token m557 = null;
[javac] ^^^^
[javac] The local variable m557 is never read
[javac] ----------
[javac] 2. WARNING in org\apache\harmony\lang\reflect\parser\SignatureParser.java
[javac] (at line 2082)
[javac] Token m559 = null;
[javac] ^^^^
[javac] The local variable m559 is never read
[javac] ----------
[javac] 2 problems (2 warnings)
Thanks
Vladimir Beliaev
> [drlvm][kernel] remove kernel classes build warnings in reflect implementation
> ------------------------------------------------------------------------------
>
> Key: HARMONY-3697
> URL: https://issues.apache.org/jira/browse/HARMONY-3697
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Attachments: H3697.patch
>
>
> Remained pack of warnings is caused by java.lang.reflect implementation classes which are:
> org\apache\harmony\fortress\security\PolicyUtils.java
> org\apache\harmony\lang\reflect\Reflection.java
> org\apache\harmony\lang\reflect\parser\SignatureParser.java
> org\apache\harmony\lang\reflect\parser\SignatureParserTokenTypes.java
> org\apache\harmony\lang\reflect\repository\ParameterizedTypeRepository.java
> org\apache\harmony\lang\reflect\repository\TypeVariableRepository.java
> org\apache\harmony\lang\reflect\repository\WildcardTypeRepository.java
> org\apache\harmony\lang\reflect\support\AuxiliaryCreator.java
> org\apache\harmony\lang\reflect\support\AuxiliaryFinder.java
> org\apache\harmony\lang\reflect\support\AuxiliaryLoader.java
> The warning cause is not yet evaluated.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3697) [drlvm][kernel] remove kernel
classes build warnings in reflect implementation
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Beliaev updated HARMONY-3697:
--------------------------------------
Description:
Remained pack of warnings is caused by java.lang.reflect implementation classes which are:
org\apache\harmony\lang\reflect\Reflection.java
org\apache\harmony\lang\reflect\parser\SignatureParser.java
org\apache\harmony\lang\reflect\parser\SignatureParserTokenTypes.java
org\apache\harmony\lang\reflect\repository\ParameterizedTypeRepository.java
org\apache\harmony\lang\reflect\repository\TypeVariableRepository.java
org\apache\harmony\lang\reflect\repository\WildcardTypeRepository.java
org\apache\harmony\lang\reflect\support\AuxiliaryCreator.java
org\apache\harmony\lang\reflect\support\AuxiliaryFinder.java
org\apache\harmony\lang\reflect\support\AuxiliaryLoader.java
The warning cause is not yet evaluated.
Thanks
Vladimir Beliaev
was:
Remained pack of warnings is caused by java.lang.reflect implementation classes which are:
org\apache\harmony\fortress\security\PolicyUtils.java
org\apache\harmony\lang\reflect\Reflection.java
org\apache\harmony\lang\reflect\parser\SignatureParser.java
org\apache\harmony\lang\reflect\parser\SignatureParserTokenTypes.java
org\apache\harmony\lang\reflect\repository\ParameterizedTypeRepository.java
org\apache\harmony\lang\reflect\repository\TypeVariableRepository.java
org\apache\harmony\lang\reflect\repository\WildcardTypeRepository.java
org\apache\harmony\lang\reflect\support\AuxiliaryCreator.java
org\apache\harmony\lang\reflect\support\AuxiliaryFinder.java
org\apache\harmony\lang\reflect\support\AuxiliaryLoader.java
The warning cause is not yet evaluated.
Thanks
Vladimir Beliaev
Patch Info: [Patch Available]
> [drlvm][kernel] remove kernel classes build warnings in reflect implementation
> ------------------------------------------------------------------------------
>
> Key: HARMONY-3697
> URL: https://issues.apache.org/jira/browse/HARMONY-3697
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Attachments: H3697.patch
>
>
> Remained pack of warnings is caused by java.lang.reflect implementation classes which are:
> org\apache\harmony\lang\reflect\Reflection.java
> org\apache\harmony\lang\reflect\parser\SignatureParser.java
> org\apache\harmony\lang\reflect\parser\SignatureParserTokenTypes.java
> org\apache\harmony\lang\reflect\repository\ParameterizedTypeRepository.java
> org\apache\harmony\lang\reflect\repository\TypeVariableRepository.java
> org\apache\harmony\lang\reflect\repository\WildcardTypeRepository.java
> org\apache\harmony\lang\reflect\support\AuxiliaryCreator.java
> org\apache\harmony\lang\reflect\support\AuxiliaryFinder.java
> org\apache\harmony\lang\reflect\support\AuxiliaryLoader.java
> The warning cause is not yet evaluated.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3697) [drlvm][kernel] remove kernel
classes build warnings in reflect implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-3697.
----------------------------------------
Resolution: Fixed
Patch applied at 531480. Please check that it was applied as expected.
> [drlvm][kernel] remove kernel classes build warnings in reflect implementation
> ------------------------------------------------------------------------------
>
> Key: HARMONY-3697
> URL: https://issues.apache.org/jira/browse/HARMONY-3697
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assigned To: Gregory Shimansky
> Attachments: H3697.patch
>
>
> Remained pack of warnings is caused by java.lang.reflect implementation classes which are:
> org\apache\harmony\lang\reflect\Reflection.java
> org\apache\harmony\lang\reflect\parser\SignatureParser.java
> org\apache\harmony\lang\reflect\parser\SignatureParserTokenTypes.java
> org\apache\harmony\lang\reflect\repository\ParameterizedTypeRepository.java
> org\apache\harmony\lang\reflect\repository\TypeVariableRepository.java
> org\apache\harmony\lang\reflect\repository\WildcardTypeRepository.java
> org\apache\harmony\lang\reflect\support\AuxiliaryCreator.java
> org\apache\harmony\lang\reflect\support\AuxiliaryFinder.java
> org\apache\harmony\lang\reflect\support\AuxiliaryLoader.java
> The warning cause is not yet evaluated.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3697) [drlvm][kernel] remove kernel
classes build warnings in reflect implementation
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490890 ]
Vladimir Beliaev commented on HARMONY-3697:
-------------------------------------------
I just kept them as a memory about remained 96 which do not exist anymore...
I fact I kept them because I would prefer making a deeper evaluation of code to be able to drop these 2 warnings. Still AFAIK this code (signature parser) is better be rewritten, so evaluating this code (which is going to be dropped off) to fix two warnings seems to be not a deal.
Anyway fill free to remove these two local variables. & Please commit the patch.
> [drlvm][kernel] remove kernel classes build warnings in reflect implementation
> ------------------------------------------------------------------------------
>
> Key: HARMONY-3697
> URL: https://issues.apache.org/jira/browse/HARMONY-3697
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assigned To: Gregory Shimansky
> Attachments: H3697.patch
>
>
> Remained pack of warnings is caused by java.lang.reflect implementation classes which are:
> org\apache\harmony\lang\reflect\Reflection.java
> org\apache\harmony\lang\reflect\parser\SignatureParser.java
> org\apache\harmony\lang\reflect\parser\SignatureParserTokenTypes.java
> org\apache\harmony\lang\reflect\repository\ParameterizedTypeRepository.java
> org\apache\harmony\lang\reflect\repository\TypeVariableRepository.java
> org\apache\harmony\lang\reflect\repository\WildcardTypeRepository.java
> org\apache\harmony\lang\reflect\support\AuxiliaryCreator.java
> org\apache\harmony\lang\reflect\support\AuxiliaryFinder.java
> org\apache\harmony\lang\reflect\support\AuxiliaryLoader.java
> The warning cause is not yet evaluated.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3697) [drlvm][kernel] remove kernel classes
build warnings in reflect implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-3697.
--------------------------------------
No response, assuming ok.
> [drlvm][kernel] remove kernel classes build warnings in reflect implementation
> ------------------------------------------------------------------------------
>
> Key: HARMONY-3697
> URL: https://issues.apache.org/jira/browse/HARMONY-3697
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assignee: Gregory Shimansky
> Attachments: H3697.patch
>
>
> Remained pack of warnings is caused by java.lang.reflect implementation classes which are:
> org\apache\harmony\lang\reflect\Reflection.java
> org\apache\harmony\lang\reflect\parser\SignatureParser.java
> org\apache\harmony\lang\reflect\parser\SignatureParserTokenTypes.java
> org\apache\harmony\lang\reflect\repository\ParameterizedTypeRepository.java
> org\apache\harmony\lang\reflect\repository\TypeVariableRepository.java
> org\apache\harmony\lang\reflect\repository\WildcardTypeRepository.java
> org\apache\harmony\lang\reflect\support\AuxiliaryCreator.java
> org\apache\harmony\lang\reflect\support\AuxiliaryFinder.java
> org\apache\harmony\lang\reflect\support\AuxiliaryLoader.java
> The warning cause is not yet evaluated.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.