You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2017/09/07 02:52:00 UTC
[jira] [Commented] (HBASE-17732) Coprocessor Design Improvements
[ https://issues.apache.org/jira/browse/HBASE-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156359#comment-16156359 ]
Hadoop QA commented on HBASE-17732:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 26s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 40 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 59s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 33m 39s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 21s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 74m 24s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 18s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 40s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 52s{color} | {color:red} hbase-endpoint in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 12s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 2m 29s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}160m 47s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.security.access.TestAccessController |
| | hadoop.hbase.client.TestEnableTable |
| | hadoop.hbase.client.TestFromClientSide3 |
| | hadoop.hbase.client.TestServerBusyException |
| | hadoop.hbase.TestJMXConnectorServer |
| | hadoop.hbase.client.TestHCM |
| | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.regionserver.TestScannerWithCorruptHFile |
| | hadoop.hbase.coprocessor.TestCoprocessorEndpoint |
| | hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint |
| | hadoop.hbase.coprocessor.TestClassLoading |
| | hadoop.hbase.coprocessor.TestSecureExport |
| | hadoop.hbase.coprocessor.TestAsyncCoprocessorEndpoint |
| Timed out junit tests | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker |
| | org.apache.hadoop.hbase.regionserver.TestRowTooBig |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy |
| | org.apache.hadoop.hbase.regionserver.TestCompaction |
| | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook |
| | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint |
| | org.apache.hadoop.hbase.wal.TestWALFiltering |
| | org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs |
| | org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator |
| | org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi |
| | org.apache.hadoop.hbase.wal.TestWALSplitCompressed |
| | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream |
| | org.apache.hadoop.hbase.master.TestGetInfoPort |
| | org.apache.hadoop.hbase.constraint.TestConstraint |
| | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence |
| | org.apache.hadoop.hbase.quotas.TestQuotaTableUtil |
| | org.apache.hadoop.hbase.mob.compactions.TestPartitionedMobCompactor |
| | org.apache.hadoop.hbase.regionserver.TestColumnSeeking |
| | org.apache.hadoop.hbase.quotas.TestRegionSizeUse |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort |
| | org.apache.hadoop.hbase.ipc.TestRpcClientLeaks |
| | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption |
| | org.apache.hadoop.hbase.master.TestTableStateManager |
| | org.apache.hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush |
| | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures |
| | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash |
| | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput |
| | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS |
| | org.apache.hadoop.hbase.master.TestSplitLogManager |
| | org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable |
| | org.apache.hadoop.hbase.TestClusterBootOrder |
| | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport |
| | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
| | org.apache.hadoop.hbase.master.TestRollingRestart |
| | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders |
| | org.apache.hadoop.hbase.quotas.TestSpaceQuotas |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded |
| | org.apache.hadoop.hbase.mob.compactions.TestMobCompactor |
| | org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential |
| | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster |
| | org.apache.hadoop.hbase.security.TestSecureIPC |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRolling |
| | org.apache.hadoop.hbase.master.TestMasterShutdown |
| | org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController |
| | org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush |
| | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster |
| | org.apache.hadoop.hbase.regionserver.TestJoinedScanners |
| | org.apache.hadoop.hbase.regionserver.wal.TestAsyncFSWAL |
| | org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController |
| | org.apache.hadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore |
| | org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner |
| | org.apache.hadoop.hbase.TestAcidGuarantees |
| | org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor |
| | org.apache.hadoop.hbase.TestGlobalMemStoreSize |
| | org.apache.hadoop.hbase.io.encoding.TestChangingEncoding |
| | org.apache.hadoop.hbase.master.assignment.TestRegionStates |
| | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks |
| | org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster |
| | org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter |
| | org.apache.hadoop.hbase.TestMovedRegionsCleaner |
| | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes |
| | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldClient |
| | org.apache.hadoop.hbase.regionserver.TestRecoveredEdits |
| | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString |
| | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency |
| | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
| | org.apache.hadoop.hbase.security.access.TestCellACLs |
| | org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths |
| | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache |
| | org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster |
| | org.apache.hadoop.hbase.wal.TestWALOpenAfterDNRollingStart |
| | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports |
| | org.apache.hadoop.hbase.security.visibility.TestWithDisabledAuthorization |
| | org.apache.hadoop.hbase.replication.TestReplicationTableBase |
| | org.apache.hadoop.hbase.master.TestRestartCluster |
| | org.apache.hadoop.hbase.TestIOFencing |
| | org.apache.hadoop.hbase.regionserver.wal.TestAsyncProtobufLog |
| | org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel |
| | org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions |
| | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk |
| | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite |
| | org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization |
| | org.apache.hadoop.hbase.TestLocalHBaseCluster |
| | org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner |
| | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack |
| | org.apache.hadoop.hbase.regionserver.wal.TestProtobufLog |
| | org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions |
| | org.apache.hadoop.hbase.quotas.TestSuperUserQuotaPermissions |
| | org.apache.hadoop.hbase.regionserver.TestClusterId |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerHostname |
| | org.apache.hadoop.hbase.security.access.TestScanEarlyTermination |
| | org.apache.hadoop.hbase.fs.TestBlockReorder |
| | org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver |
| | org.apache.hadoop.hbase.regionserver.TestHRegionReplayEvents |
| | org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort |
| | org.apache.hadoop.hbase.io.hfile.TestHFileBlock |
| | org.apache.hadoop.hbase.replication.TestMultiSlaveReplication |
| | org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover |
| | org.apache.hadoop.hbase.util.TestConnectionCache |
| | org.apache.hadoop.hbase.client.TestBlockEvictionFromClient |
| | org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy |
| | org.apache.hadoop.hbase.wal.TestWALFactory |
| | org.apache.hadoop.hbase.security.access.TestZKPermissionWatcher |
| | org.apache.hadoop.hbase.regionserver.TestStore |
| | org.apache.hadoop.hbase.wal.TestFSHLogProvider |
| | org.apache.hadoop.hbase.util.TestIdReadWriteLock |
| | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad |
| | org.apache.hadoop.hbase.replication.TestMasterReplication |
| | org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManagerZkImpl |
| | org.apache.hadoop.hbase.client.TestAsyncAdminBuilder |
| | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOnNewVersionBehaviorTable |
| | org.apache.hadoop.hbase.replication.TestReplicationSource |
| | org.apache.hadoop.hbase.regionserver.TestAtomicOperation |
| | org.apache.hadoop.hbase.tool.TestCanaryTool |
| | org.apache.hadoop.hbase.io.TestFileLink |
| | org.apache.hadoop.hbase.regionserver.wal.TestDurability |
| | org.apache.hadoop.hbase.regionserver.TestMajorCompaction |
| | org.apache.hadoop.hbase.regionserver.TestCompactionArchiveIOException |
| | org.apache.hadoop.hbase.util.TestFSUtils |
| | org.apache.hadoop.hbase.wal.TestWALSplit |
| | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-17732 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12885708/HBASE-17732.master.004.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a2f2c63a5b4a 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
| git revision | master / fd49a98 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8486/artifact/patchprocess/patch-unit-hbase-server.txt |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8486/artifact/patchprocess/patch-unit-hbase-endpoint.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8486/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/8486/artifact/patchprocess/patch-asflicense-problems.txt |
| modules | C: hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-endpoint hbase-examples U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8486/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Coprocessor Design Improvements
> -------------------------------
>
> Key: HBASE-17732
> URL: https://issues.apache.org/jira/browse/HBASE-17732
> Project: HBase
> Issue Type: Improvement
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-17732.master.001.patch, HBASE-17732.master.002.patch, HBASE-17732.master.003.patch, HBASE-17732.master.004.patch
>
>
> The two main changes are:
> * *Adding template for coprocessor type to CoprocessorEnvironment i.e. {{interface CoprocessorEnvironment<C extends Coprocessor>}}*
> ** Enables us to load only relevant coprocessors in hosts. Right now each type of host loads all types of coprocs and it's only during execOperation that it checks if the coproc is of correct type i.e. XCoprocessorHost will load XObserver, YObserver, and all others, and will check in execOperation if {{coproc instanceOf XObserver}} and ignore the rest.
> ** Allow sharing of a bunch functions/classes which are currently duplicated in each host. For eg. CoprocessorOperations, CoprocessorOperationWithResult, execOperations().
> * *Introduce 4 coprocessor classes and use composition between these new classes and and old observers*
> ** The real gold here is, moving forward, we'll be able to break down giant everything-in-one observers (masterobserver has 100+ functions) into smaller, more focused observers. These smaller observer can then have different compat guarantees!!
> Here's a more detailed design doc: https://docs.google.com/document/d/1PBEnaqyJeiHvALFswF_yl81-rOpQmZuixCDua-LT9X4/edit
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)