You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/21 02:06:28 UTC

[GitHub] [spark] wangjiaochun commented on issue #24127: [SPARK-27186][CORE] optimize sortshuffle write

wangjiaochun commented on issue #24127: [SPARK-27186][CORE] optimize sortshuffle write
URL: https://github.com/apache/spark/pull/24127#issuecomment-475091856
 
 
   The underlying Iterator do nothing.
   so I think it's worth revising. first, ExternalSorter-instantiated is expensive operation, such as there is need to 
   estimate the size of all the collection of the Instances. Also create tmp file is needless.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org