You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ggershinsky (via GitHub)" <gi...@apache.org> on 2023/03/12 08:32:43 UTC

[GitHub] [iceberg] ggershinsky commented on a diff in pull request #6762: Deliver key metadata to parquet readers

ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1133209135


##########
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -419,6 +421,12 @@ private CloseableIterable<T> newParquetIterable(
           if (nameMapping != null) {
             parquetReadBuilder.withNameMapping(NameMappingParser.fromJson(nameMapping));
           }
+          if (task.file().keyMetadata() != null) {

Review Comment:
   Added empty lines after each block in this PR, per the comment above. If other style guidelines are meant, please let me know.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org