You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "zhangwl9 (via GitHub)" <gi...@apache.org> on 2024/12/31 09:57:25 UTC

[I] [Improvement]: Convert the sorter creation within the SchedulingPolicy into a plugin-style implementation [amoro]

zhangwl9 opened a new issue, #3382:
URL: https://github.com/apache/amoro/issues/3382

   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   The SchedulingPolicy within the plan module creates a corresponding Sorter based on the SchedulingPolicy#policyName. This Sorter sorts the TableRuntimes from the input TableRuntimeList, determining the order in which the TableRuntimes will undergo scheduling optimization. 
   However, the current code requires significant changes when adding new policy sorter instance, making it difficult to quickly and easily implement new additions
   
   ### How should we improve?
   
   1、Add a new SorterFactory interface, specifying common methods for all policy sorters.
   2、In the SchedulingPolicy#createSorterByPolicy method, use SPI to load the policy sorter instances.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Subtasks
   
   _No response_
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Improvement]: Convert the sorter creation within the SchedulingPolicy into a plugin-style implementation [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong closed issue #3382: [Improvement]: Convert the sorter creation within the SchedulingPolicy into a plugin-style implementation
URL: https://github.com/apache/amoro/issues/3382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Improvement]: Convert the sorter creation within the SchedulingPolicy into a plugin-style implementation [amoro]

Posted by "zhangwl9 (via GitHub)" <gi...@apache.org>.
zhangwl9 commented on issue #3382:
URL: https://github.com/apache/amoro/issues/3382#issuecomment-2575111689

   @klion26 @czy006 @baiyangtx Could you please take a look at this when you're free, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org