You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Robbie Gemmell <ro...@gmail.com> on 2011/02/14 17:53:59 UTC
[VOTE] add a pre-commit hook to check for JIRA references
For those who didn't follow the recent discussion, I recently raised
the issue of our poor use of JIRA and inclusion of JIRA references
within svn commit log messages. A quick check of the prior 3 months
commits showed barely over 30% of them had a JIRA reference, which is
far lower than it should have been.
During the discussion I suggested we add a pre-commit hook to enforce
use of JIRA references where appropriate. One suggestion I made was
that this would block all commits that don't have a Qpid JIRA
reference unless they instead contained eg 'NO-JIRA', which could be
used to bypass the hook on demand. Any commit which failed to meet
these cases would be rejected with a message alerting the committer
how to resolve the issue, i.e. include a JIRA reference if appropriate
or signal their intent to bypass the requirement. This means noone
would ever be prevented from committing what they want when they want,
but still removes the possibility of JIRA references being left out
due to merely forgetting them, and means that if/when we later review
the commits we can identify where people have chosen to purposely
bypass the requirement.
I haven't seen any objections to such a system, but to ensure everyone
gets a say I wanted to call this vote to establish the way forward. As
per indication at http://www.apache.org/foundation/voting.html the
vote will be conducted on a majority rules basis, and I propose that
the vote is open equally to all committers and not just PMC members.
The vote will close at 5pm GMT on Thursday 17th February (i.e. approx
72hrs from now).
Please reply with your +1 / -1 vote, or cross one of the boxes below:
[ ] +1, I accept the proposal and vote to add the svn pre-commit
hook as outlined above.
[ ] -1, I reject the proposal and vote not to add the svn pre-commit
hook outlined above.
Regards,
Robbie
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Andrew Kennedy <an...@gmail.com>.
> [X] +1, I accept the proposal and vote to add the svn pre-commit
> hook as outlined above.
> [ ] -1, I reject the proposal and vote not to add the svn pre-
> commit hook outlined above.
+1, then.
Andrew.
--
-- andrew d kennedy ? do not fold, bend, spindle, or mutilate ;
-- http://grkvlt.blogspot.com/ ? edinburgh : +44 7582 293 255 ;
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Gordon Sim <gs...@redhat.com>.
[X] +1, I accept the proposal and vote to add the svn pre-commit
hook as outlined above.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Ken Giusti <kg...@redhat.com>.
[X] +1, I accept the proposal and vote to add the svn pre-commit
hook as outlined above.
-K
----- Original Message -----
> On 15 Feb 2011, at 13:56, Ted Ross wrote:
> > +1 but I would like to see a crisper definition of the proposal:
> >
> > Commits are rejected unless the commit comment contains a valid
> > QPID-<number> Jira reference OR 'NO-JIRA'. A Jira reference is
> > valid if it references an existing issue in the Qpid project.
>
> I don't know if this is what is used on the ASF Subversion
> repository, but it *is* the 'official' JIRA way of doing what you
> want:
>
> https://studio.plugins.atlassian.com/wiki/display/CMMT/JIRA+Commit
> +Acceptance
>
> Also, here's a 'crisper definition' I prepared earlier:
>
> https://cwiki.apache.org/confluence/display/qpid/Subversion+Commit
> +Comment+Format
>
> Cheers,
> Andrew.
> --
> -- andrew d kennedy ? do not fold, bend, spindle, or mutilate ;
> -- http://grkvlt.blogspot.com/ ? edinburgh : +44 7582 293 255 ;
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Andrew Kennedy <an...@gmail.com>.
On 15 Feb 2011, at 13:56, Ted Ross wrote:
> +1 but I would like to see a crisper definition of the proposal:
>
> Commits are rejected unless the commit comment contains a valid
> QPID-<number> Jira reference OR 'NO-JIRA'. A Jira reference is
> valid if it references an existing issue in the Qpid project.
I don't know if this is what is used on the ASF Subversion
repository, but it *is* the 'official' JIRA way of doing what you want:
https://studio.plugins.atlassian.com/wiki/display/CMMT/JIRA+Commit
+Acceptance
Also, here's a 'crisper definition' I prepared earlier:
https://cwiki.apache.org/confluence/display/qpid/Subversion+Commit
+Comment+Format
Cheers,
Andrew.
--
-- andrew d kennedy ? do not fold, bend, spindle, or mutilate ;
-- http://grkvlt.blogspot.com/ ? edinburgh : +44 7582 293 255 ;
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Ted Ross <tr...@redhat.com>.
+1 but I would like to see a crisper definition of the proposal:
Commits are rejected unless the commit comment contains a valid
QPID-<number> Jira reference OR 'NO-JIRA'. A Jira reference is valid if
it references an existing issue in the Qpid project.
-Ted
On 02/14/2011 11:53 AM, Robbie Gemmell wrote:
> For those who didn't follow the recent discussion, I recently raised
> the issue of our poor use of JIRA and inclusion of JIRA references
> within svn commit log messages. A quick check of the prior 3 months
> commits showed barely over 30% of them had a JIRA reference, which is
> far lower than it should have been.
>
> During the discussion I suggested we add a pre-commit hook to enforce
> use of JIRA references where appropriate. One suggestion I made was
> that this would block all commits that don't have a Qpid JIRA
> reference unless they instead contained eg 'NO-JIRA', which could be
> used to bypass the hook on demand. Any commit which failed to meet
> these cases would be rejected with a message alerting the committer
> how to resolve the issue, i.e. include a JIRA reference if appropriate
> or signal their intent to bypass the requirement. This means noone
> would ever be prevented from committing what they want when they want,
> but still removes the possibility of JIRA references being left out
> due to merely forgetting them, and means that if/when we later review
> the commits we can identify where people have chosen to purposely
> bypass the requirement.
>
> I haven't seen any objections to such a system, but to ensure everyone
> gets a say I wanted to call this vote to establish the way forward. As
> per indication at http://www.apache.org/foundation/voting.html the
> vote will be conducted on a majority rules basis, and I propose that
> the vote is open equally to all committers and not just PMC members.
> The vote will close at 5pm GMT on Thursday 17th February (i.e. approx
> 72hrs from now).
>
> Please reply with your +1 / -1 vote, or cross one of the boxes below:
>
> [ ] +1, I accept the proposal and vote to add the svn pre-commit
> hook as outlined above.
> [ ] -1, I reject the proposal and vote not to add the svn pre-commit
> hook outlined above.
>
>
> Regards,
> Robbie
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Kim van der Riet <ki...@redhat.com>.
+1
On Mon, 2011-02-14 at 16:53 +0000, Robbie Gemmell wrote:
> Please reply with your +1 / -1 vote, or cross one of the boxes below:
>
> [ ] +1, I accept the proposal and vote to add the svn pre-commit
> hook as outlined above.
> [ ] -1, I reject the proposal and vote not to add the svn pre-commit
> hook outlined above.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Marnie McCormack <ma...@googlemail.com>.
+1
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Jonathan Robie <jo...@redhat.com>.
+1
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Martin Ritchie <ri...@apache.org>.
+1
On 14 February 2011 22:46, Rajith Attapattu <ra...@gmail.com> wrote:
> +1
>
> Rajith
>
> On Mon, Feb 14, 2011 at 4:16 PM, Alan Conway <ac...@redhat.com> wrote:
>
>> +1
>>
>>
>> On 02/14/2011 11:53 AM, Robbie Gemmell wrote:
>>
>>> For those who didn't follow the recent discussion, I recently raised
>>> the issue of our poor use of JIRA and inclusion of JIRA references
>>> within svn commit log messages. A quick check of the prior 3 months
>>> commits showed barely over 30% of them had a JIRA reference, which is
>>> far lower than it should have been.
>>>
>>> During the discussion I suggested we add a pre-commit hook to enforce
>>> use of JIRA references where appropriate. One suggestion I made was
>>> that this would block all commits that don't have a Qpid JIRA
>>> reference unless they instead contained eg 'NO-JIRA', which could be
>>> used to bypass the hook on demand. Any commit which failed to meet
>>> these cases would be rejected with a message alerting the committer
>>> how to resolve the issue, i.e. include a JIRA reference if appropriate
>>> or signal their intent to bypass the requirement. This means noone
>>> would ever be prevented from committing what they want when they want,
>>> but still removes the possibility of JIRA references being left out
>>> due to merely forgetting them, and means that if/when we later review
>>> the commits we can identify where people have chosen to purposely
>>> bypass the requirement.
>>>
>>> I haven't seen any objections to such a system, but to ensure everyone
>>> gets a say I wanted to call this vote to establish the way forward. As
>>> per indication at http://www.apache.org/foundation/voting.html the
>>> vote will be conducted on a majority rules basis, and I propose that
>>> the vote is open equally to all committers and not just PMC members.
>>> The vote will close at 5pm GMT on Thursday 17th February (i.e. approx
>>> 72hrs from now).
>>>
>>> Please reply with your +1 / -1 vote, or cross one of the boxes below:
>>>
>>> [ ] +1, I accept the proposal and vote to add the svn pre-commit
>>> hook as outlined above.
>>> [ ] -1, I reject the proposal and vote not to add the svn pre-commit
>>> hook outlined above.
>>>
>>>
>>> Regards,
>>> Robbie
>>>
>>> ---------------------------------------------------------------------
>>> Apache Qpid - AMQP Messaging Implementation
>>> Project: http://qpid.apache.org
>>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>>
>>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project: http://qpid.apache.org
>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>
>>
>
>
> --
> Regards,
>
> Rajith Attapattu
> Red Hat
> http://rajith.2rlabs.com/
>
--
Martin Ritchie
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Rajith Attapattu <ra...@gmail.com>.
+1
Rajith
On Mon, Feb 14, 2011 at 4:16 PM, Alan Conway <ac...@redhat.com> wrote:
> +1
>
>
> On 02/14/2011 11:53 AM, Robbie Gemmell wrote:
>
>> For those who didn't follow the recent discussion, I recently raised
>> the issue of our poor use of JIRA and inclusion of JIRA references
>> within svn commit log messages. A quick check of the prior 3 months
>> commits showed barely over 30% of them had a JIRA reference, which is
>> far lower than it should have been.
>>
>> During the discussion I suggested we add a pre-commit hook to enforce
>> use of JIRA references where appropriate. One suggestion I made was
>> that this would block all commits that don't have a Qpid JIRA
>> reference unless they instead contained eg 'NO-JIRA', which could be
>> used to bypass the hook on demand. Any commit which failed to meet
>> these cases would be rejected with a message alerting the committer
>> how to resolve the issue, i.e. include a JIRA reference if appropriate
>> or signal their intent to bypass the requirement. This means noone
>> would ever be prevented from committing what they want when they want,
>> but still removes the possibility of JIRA references being left out
>> due to merely forgetting them, and means that if/when we later review
>> the commits we can identify where people have chosen to purposely
>> bypass the requirement.
>>
>> I haven't seen any objections to such a system, but to ensure everyone
>> gets a say I wanted to call this vote to establish the way forward. As
>> per indication at http://www.apache.org/foundation/voting.html the
>> vote will be conducted on a majority rules basis, and I propose that
>> the vote is open equally to all committers and not just PMC members.
>> The vote will close at 5pm GMT on Thursday 17th February (i.e. approx
>> 72hrs from now).
>>
>> Please reply with your +1 / -1 vote, or cross one of the boxes below:
>>
>> [ ] +1, I accept the proposal and vote to add the svn pre-commit
>> hook as outlined above.
>> [ ] -1, I reject the proposal and vote not to add the svn pre-commit
>> hook outlined above.
>>
>>
>> Regards,
>> Robbie
>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project: http://qpid.apache.org
>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>
>>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
--
Regards,
Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Alan Conway <ac...@redhat.com>.
+1
On 02/14/2011 11:53 AM, Robbie Gemmell wrote:
> For those who didn't follow the recent discussion, I recently raised
> the issue of our poor use of JIRA and inclusion of JIRA references
> within svn commit log messages. A quick check of the prior 3 months
> commits showed barely over 30% of them had a JIRA reference, which is
> far lower than it should have been.
>
> During the discussion I suggested we add a pre-commit hook to enforce
> use of JIRA references where appropriate. One suggestion I made was
> that this would block all commits that don't have a Qpid JIRA
> reference unless they instead contained eg 'NO-JIRA', which could be
> used to bypass the hook on demand. Any commit which failed to meet
> these cases would be rejected with a message alerting the committer
> how to resolve the issue, i.e. include a JIRA reference if appropriate
> or signal their intent to bypass the requirement. This means noone
> would ever be prevented from committing what they want when they want,
> but still removes the possibility of JIRA references being left out
> due to merely forgetting them, and means that if/when we later review
> the commits we can identify where people have chosen to purposely
> bypass the requirement.
>
> I haven't seen any objections to such a system, but to ensure everyone
> gets a say I wanted to call this vote to establish the way forward. As
> per indication at http://www.apache.org/foundation/voting.html the
> vote will be conducted on a majority rules basis, and I propose that
> the vote is open equally to all committers and not just PMC members.
> The vote will close at 5pm GMT on Thursday 17th February (i.e. approx
> 72hrs from now).
>
> Please reply with your +1 / -1 vote, or cross one of the boxes below:
>
> [ ] +1, I accept the proposal and vote to add the svn pre-commit
> hook as outlined above.
> [ ] -1, I reject the proposal and vote not to add the svn pre-commit
> hook outlined above.
>
>
> Regards,
> Robbie
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [RESULT] [VOTE] add a pre-commit hook to check for JIRA
references
Posted by Chuck Rolke <cr...@redhat.com>.
Robbie,
Thanks for driving this. I can't do two commits without flubbing the JIRA reference.
-Chuck
----- Original Message -----
> From: "Robbie Gemmell" <ro...@gmail.com>
> To: dev@qpid.apache.org
> Sent: Thursday, February 17, 2011 1:24:44 PM
> Subject: [RESULT] [VOTE] add a pre-commit hook to check for JIRA references
> The vote is now closed. There were 14 +1 votes and no other votes,
> meaning the proposal was passed.
>
> I will approach Infra in the days ahead about implementing the commit
> hook.
>
> Robbie
>
> On 14 February 2011 16:53, Robbie Gemmell <ro...@gmail.com>
> wrote:
> > For those who didn't follow the recent discussion, I recently raised
> > the issue of our poor use of JIRA and inclusion of JIRA references
> > within svn commit log messages. A quick check of the prior 3 months
> > commits showed barely over 30% of them had a JIRA reference, which
> > is
> > far lower than it should have been.
> >
> > During the discussion I suggested we add a pre-commit hook to
> > enforce
> > use of JIRA references where appropriate. One suggestion I made was
> > that this would block all commits that don't have a Qpid JIRA
> > reference unless they instead contained eg 'NO-JIRA', which could be
> > used to bypass the hook on demand. Any commit which failed to meet
> > these cases would be rejected with a message alerting the committer
> > how to resolve the issue, i.e. include a JIRA reference if
> > appropriate
> > or signal their intent to bypass the requirement. This means noone
> > would ever be prevented from committing what they want when they
> > want,
> > but still removes the possibility of JIRA references being left out
> > due to merely forgetting them, and means that if/when we later
> > review
> > the commits we can identify where people have chosen to purposely
> > bypass the requirement.
> >
> > I haven't seen any objections to such a system, but to ensure
> > everyone
> > gets a say I wanted to call this vote to establish the way forward.
> > As
> > per indication at http://www.apache.org/foundation/voting.html the
> > vote will be conducted on a majority rules basis, and I propose that
> > the vote is open equally to all committers and not just PMC members.
> > The vote will close at 5pm GMT on Thursday 17th February (i.e.
> > approx
> > 72hrs from now).
> >
> > Please reply with your +1 / -1 vote, or cross one of the boxes
> > below:
> >
> > [ ] +1, I accept the proposal and vote to add the svn pre-commit
> > hook as outlined above.
> > [ ] -1, I reject the proposal and vote not to add the svn pre-commit
> > hook outlined above.
> >
> >
> > Regards,
> > Robbie
> >
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[RESULT] [VOTE] add a pre-commit hook to check for JIRA references
Posted by Robbie Gemmell <ro...@gmail.com>.
The vote is now closed. There were 14 +1 votes and no other votes,
meaning the proposal was passed.
I will approach Infra in the days ahead about implementing the commit hook.
Robbie
On 14 February 2011 16:53, Robbie Gemmell <ro...@gmail.com> wrote:
> For those who didn't follow the recent discussion, I recently raised
> the issue of our poor use of JIRA and inclusion of JIRA references
> within svn commit log messages. A quick check of the prior 3 months
> commits showed barely over 30% of them had a JIRA reference, which is
> far lower than it should have been.
>
> During the discussion I suggested we add a pre-commit hook to enforce
> use of JIRA references where appropriate. One suggestion I made was
> that this would block all commits that don't have a Qpid JIRA
> reference unless they instead contained eg 'NO-JIRA', which could be
> used to bypass the hook on demand. Any commit which failed to meet
> these cases would be rejected with a message alerting the committer
> how to resolve the issue, i.e. include a JIRA reference if appropriate
> or signal their intent to bypass the requirement. This means noone
> would ever be prevented from committing what they want when they want,
> but still removes the possibility of JIRA references being left out
> due to merely forgetting them, and means that if/when we later review
> the commits we can identify where people have chosen to purposely
> bypass the requirement.
>
> I haven't seen any objections to such a system, but to ensure everyone
> gets a say I wanted to call this vote to establish the way forward. As
> per indication at http://www.apache.org/foundation/voting.html the
> vote will be conducted on a majority rules basis, and I propose that
> the vote is open equally to all committers and not just PMC members.
> The vote will close at 5pm GMT on Thursday 17th February (i.e. approx
> 72hrs from now).
>
> Please reply with your +1 / -1 vote, or cross one of the boxes below:
>
> [ ] +1, I accept the proposal and vote to add the svn pre-commit
> hook as outlined above.
> [ ] -1, I reject the proposal and vote not to add the svn pre-commit
> hook outlined above.
>
>
> Regards,
> Robbie
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Andrew Stitcher <as...@redhat.com>.
On Mon, 2011-02-14 at 16:53 +0000, Robbie Gemmell wrote:
> I haven't seen any objections to such a system, but to ensure everyone
> gets a say I wanted to call this vote to establish the way forward. As
> per indication at http://www.apache.org/foundation/voting.html the
> vote will be conducted on a majority rules basis, and I propose that
> the vote is open equally to all committers and not just PMC members.
> The vote will close at 5pm GMT on Thursday 17th February (i.e. approx
> 72hrs from now).
>
> Please reply with your +1 / -1 vote, or cross one of the boxes below:
+1
Andrew
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by mick <mg...@redhat.com>.
On Mon, 2011-02-14 at 16:53 +0000, Robbie Gemmell wrote:
> block all commits that don't have a Qpid JIRA
> reference unless they instead contained eg 'NO-JIRA'
+1 for that ^^^
hard to argue with this one...
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Chuck Rolke <cr...@redhat.com>.
[X] +1, I accept the proposal and vote to add the svn pre-commit
hook as outlined above.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
RE: [VOTE] add a pre-commit hook to check for JIRA references
Posted by Steve Huston <sh...@riverace.com>.
+1
-Steve
> -----Original Message-----
> From: Robbie Gemmell [mailto:robbie.gemmell@gmail.com]
> Sent: Monday, February 14, 2011 11:54 AM
> To: dev@qpid.apache.org
> Subject: [VOTE] add a pre-commit hook to check for JIRA references
>
>
> For those who didn't follow the recent discussion, I recently
> raised the issue of our poor use of JIRA and inclusion of
> JIRA references within svn commit log messages. A quick check
> of the prior 3 months commits showed barely over 30% of them
> had a JIRA reference, which is far lower than it should have been.
>
> During the discussion I suggested we add a pre-commit hook to
> enforce use of JIRA references where appropriate. One
> suggestion I made was that this would block all commits that
> don't have a Qpid JIRA reference unless they instead
> contained eg 'NO-JIRA', which could be used to bypass the
> hook on demand. Any commit which failed to meet these cases
> would be rejected with a message alerting the committer how
> to resolve the issue, i.e. include a JIRA reference if
> appropriate or signal their intent to bypass the requirement.
> This means noone would ever be prevented from committing what
> they want when they want, but still removes the possibility
> of JIRA references being left out due to merely forgetting
> them, and means that if/when we later review the commits we
> can identify where people have chosen to purposely bypass the
> requirement.
>
> I haven't seen any objections to such a system, but to ensure
> everyone gets a say I wanted to call this vote to establish
> the way forward. As per indication at
> http://www.apache.org/foundation/voting.html the vote will be
> conducted on a majority rules basis, and I propose that the
> vote is open equally to all committers and not just PMC
> members. The vote will close at 5pm GMT on Thursday 17th
> February (i.e. approx 72hrs from now).
>
> Please reply with your +1 / -1 vote, or cross one of the boxes below:
>
> [ ] +1, I accept the proposal and vote to add the svn
> pre-commit hook as outlined above. [ ] -1, I reject the
> proposal and vote not to add the svn pre-commit hook outlined above.
>
>
> Regards,
> Robbie
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org