You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@joshua.apache.org by mj...@apache.org on 2016/08/22 21:47:49 UTC
[23/27] incubator-joshua git commit: small cleanup
small cleanup
Project: http://git-wip-us.apache.org/repos/asf/incubator-joshua/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-joshua/commit/25d28fe2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-joshua/tree/25d28fe2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-joshua/diff/25d28fe2
Branch: refs/heads/master
Commit: 25d28fe2ce32a4b130a4412e982d6e16d5af8afc
Parents: cd3ff0c
Author: Matt Post <po...@cs.jhu.edu>
Authored: Sun Aug 21 07:24:58 2016 -0500
Committer: Matt Post <po...@cs.jhu.edu>
Committed: Sun Aug 21 07:24:58 2016 -0500
----------------------------------------------------------------------
src/main/java/org/apache/joshua/decoder/phrase/Stacks.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-joshua/blob/25d28fe2/src/main/java/org/apache/joshua/decoder/phrase/Stacks.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/joshua/decoder/phrase/Stacks.java b/src/main/java/org/apache/joshua/decoder/phrase/Stacks.java
index dd56eb0..077daff 100644
--- a/src/main/java/org/apache/joshua/decoder/phrase/Stacks.java
+++ b/src/main/java/org/apache/joshua/decoder/phrase/Stacks.java
@@ -167,15 +167,13 @@ public class Stacks {
continue;
}
- /* We have found a permissible phrase start point and length, that fits with the current
- * coverage vector. Record that in a Span.
- */
- Span span = new Span(begin, begin + phrase_length);
-
// Don't append </s> until the end
if (begin == sentence.length() - 1 && source_words != sentence.length())
continue;
+ /* We have found a permissible phrase start point and length for the current coverage
+ * vector. Find all the phrases over that span.
+ */
TargetPhrases phrases = chart.getRange(begin, begin + phrase_length);
if (phrases == null)
continue;