You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2014/03/20 08:29:09 UTC
Review Request 19452: ACCUMULO-2382 Using non-default CONTINUOUS_CONF_DIR
breaks agitation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19452/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-2382
https://issues.apache.org/jira/browse/ACCUMULO-2382
Repository: accumulo
Description
-------
This is the fix for separating out things that we expect in the CONTINUOUS_CONF_DIR and things we expect in our install location. Essentially, if we ship with just an example version, it goes in CONF_DIR and otherwise it doesn't.
Patch is actually two parts, one that applies just to 1.5.x and one that finished the changes needed for 1.6. Since the 1.5 -> 1.6 merge is clean, I'm just making a RB for the final product in the 1.6 branch.
Diffs
-----
test/system/continuous/datanode-agitator.pl f823593
test/system/continuous/master-agitator.pl a40bfb2
test/system/continuous/run-moru.sh 18f98e1
test/system/continuous/run-verify.sh e6a87b3
test/system/continuous/start-agitator.sh 979899f
test/system/continuous/tserver-agitator.pl befc097
Diff: https://reviews.apache.org/r/19452/diff/
Testing
-------
stood up a 1.5 cluster based on this patch, successfully ran agitation in the presence of a customized CONTINUOUS_CONF_DIR. Upgraded cluster to 1.6 with the final part of this patch in place, successfully used the run-verify.sh shell script.
Thanks,
Sean Busbey
Re: Review Request 19452: ACCUMULO-2382 Using non-default
CONTINUOUS_CONF_DIR breaks agitation
Posted by Eric Newton <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19452/#review37877
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Newton
On March 20, 2014, 7:29 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19452/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 7:29 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2382
> https://issues.apache.org/jira/browse/ACCUMULO-2382
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> This is the fix for separating out things that we expect in the CONTINUOUS_CONF_DIR and things we expect in our install location. Essentially, if we ship with just an example version, it goes in CONF_DIR and otherwise it doesn't.
>
> Patch is actually two parts, one that applies just to 1.5.x and one that finished the changes needed for 1.6. Since the 1.5 -> 1.6 merge is clean, I'm just making a RB for the final product in the 1.6 branch.
>
>
> Diffs
> -----
>
> test/system/continuous/datanode-agitator.pl f823593
> test/system/continuous/master-agitator.pl a40bfb2
> test/system/continuous/run-moru.sh 18f98e1
> test/system/continuous/run-verify.sh e6a87b3
> test/system/continuous/start-agitator.sh 979899f
> test/system/continuous/tserver-agitator.pl befc097
>
> Diff: https://reviews.apache.org/r/19452/diff/
>
>
> Testing
> -------
>
> stood up a 1.5 cluster based on this patch, successfully ran agitation in the presence of a customized CONTINUOUS_CONF_DIR. Upgraded cluster to 1.6 with the final part of this patch in place, successfully used the run-verify.sh shell script.
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 19452: ACCUMULO-2382 Using non-default
CONTINUOUS_CONF_DIR breaks agitation
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19452/#review37889
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Havanki
On March 20, 2014, 3:29 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19452/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 3:29 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2382
> https://issues.apache.org/jira/browse/ACCUMULO-2382
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> This is the fix for separating out things that we expect in the CONTINUOUS_CONF_DIR and things we expect in our install location. Essentially, if we ship with just an example version, it goes in CONF_DIR and otherwise it doesn't.
>
> Patch is actually two parts, one that applies just to 1.5.x and one that finished the changes needed for 1.6. Since the 1.5 -> 1.6 merge is clean, I'm just making a RB for the final product in the 1.6 branch.
>
>
> Diffs
> -----
>
> test/system/continuous/datanode-agitator.pl f823593
> test/system/continuous/master-agitator.pl a40bfb2
> test/system/continuous/run-moru.sh 18f98e1
> test/system/continuous/run-verify.sh e6a87b3
> test/system/continuous/start-agitator.sh 979899f
> test/system/continuous/tserver-agitator.pl befc097
>
> Diff: https://reviews.apache.org/r/19452/diff/
>
>
> Testing
> -------
>
> stood up a 1.5 cluster based on this patch, successfully ran agitation in the presence of a customized CONTINUOUS_CONF_DIR. Upgraded cluster to 1.6 with the final part of this patch in place, successfully used the run-verify.sh shell script.
>
>
> Thanks,
>
> Sean Busbey
>
>